[elbe-devel] [PATCH v3 00/75] tree-wide: use f-strings

Bastian Germann bage at linutronix.de
Sun Nov 6 23:01:48 CET 2022


Please also test `./elbe initvm --devel create` which fails to run sucessfully with the series applied.
And please create a GitHub pull request instead of sending any subsequent patch series of this size.

Am 06.11.22 um 22:11 schrieb Daniel Braunwarth:
> This series of patches replaces all "old-school" string formatting by
> f-strings.
> 
> This "fixes" all (668) pylint messages "consider-using-f-string / C0209".
> 
> See https://pylint.pycqa.org/en/latest/user_guide/messages/convention/consider-using-f-string.html
> 
> This improves pylint's rating from 8.73 to 9.28 out of 10.
> 
> Changes since v1:
> - Only resend because of mailing list restrictions
> 
> Changes since v2:
> - Add missing "f" to strings (debinstaller, elbeproject, hashes and rfs)
> 
> Daniel Braunwarth (75):
>    add: use f-strings
>    bootup-check: use f-strings
>    check_updates: use f-strings
>    check-build: use f-strings
>    chroot: use f-strings
>    control: use f-strings
>    daemon: use f-strings
>    diff: use f-strings
>    fetch_initvm: use f-strings
>    init: use f-strings
>    parselicence: use f-strings
>    pkgdiff: use f-strings
>    preprocess: use f-strings
>    prjrepo: use f-strings
>    remove_sign: use f-strings
>    repodir: use f-strings
>    setsel: use f-strings
>    show: use f-strings
>    test: use f-strings
>    toolchainextract: use f-strings
>    validate: use f-strings
>    authentiaction: use f-strings
>    esoap: use f-strings
>    faults: use f-strings
>    barebox: use f-strings
>    kernel: use f-strings
>    uboot: use f-strings
>    button: use f-strings
>    form: use f-strings
>    edit: use f-strings
>    test_preproc: use f-strings
>    test_pylint: use f-strings
>    test_xml: use f-strings
>    aptpkgutils: use f-strings
>    aptprogress: use f-strings
>    archivedir: use f-strings
>    asyncworker: use f-strings
>    cdroms: use f-strings
>    db: use f-strings
>    dbaction: use f-strings
>    debinstaller: use f-strings
>    debpkg: use f-strings
>    dump: use f-strings
>    efilesystem: use f-strings
>    egpg: use f-strings
>    elbexml: use f-strings
>    filesystem: use f-strings
>    finetuning: use f-strings
>    fstab: use f-strings
>    hashes: use f-strings
>    hdimg: use f-strings
>    initvmaction: use f-strings
>    junit: use f-strings
>    licencexml: use f-strings
>    log: use f-strings
>    packers: use f-strings
>    pbuilder: use f-strings
>    pbuilderaction: use f-strings
>    pkgarchive: use f-strings
>    xmldefaults: use f-strings
>    updatepkg: use f-strings
>    updated: use f-strings
>    updated_monitors: use f-strings
>    treeutils: use f-strings
>    templates: use f-strings
>    soapclient: use f-strings
>    shellhelper: use f-strings
>    rpcaptcache: use f-strings
>    projectmanager: use f-strings
>    elbeproject: use f-strings
>    pkgutils: use f-strings
>    repomanager: use f-strings
>    rfs: use f-strings
>    virtapt: use f-strings
>    xmlpreprocess: use f-strings
> 
>   elbepack/aptpkgutils.py                 |  11 +-
>   elbepack/aptprogress.py                 |   4 +-
>   elbepack/archivedir.py                  |  10 +-
>   elbepack/asyncworker.py                 |  19 +-
>   elbepack/cdroms.py                      |  19 +-
>   elbepack/commands/add.py                |   6 +-
>   elbepack/commands/bootup-check.py       |   6 +-
>   elbepack/commands/check-build.py        |  34 ++--
>   elbepack/commands/check_updates.py      |  18 +-
>   elbepack/commands/chroot.py             |   6 +-
>   elbepack/commands/control.py            |  30 ++--
>   elbepack/commands/daemon.py             |   4 +-
>   elbepack/commands/diff.py               |  28 ++-
>   elbepack/commands/fetch_initvm_pkgs.py  |  10 +-
>   elbepack/commands/init.py               |  19 +-
>   elbepack/commands/parselicence.py       |  64 +++----
>   elbepack/commands/pkgdiff.py            |   8 +-
>   elbepack/commands/preprocess.py         |   2 +-
>   elbepack/commands/prjrepo.py            |  26 +--
>   elbepack/commands/remove_sign.py        |   2 +-
>   elbepack/commands/repodir.py            |   2 +-
>   elbepack/commands/setsel.py             |   2 +-
>   elbepack/commands/show.py               |  27 +--
>   elbepack/commands/test.py               |   7 +-
>   elbepack/commands/toolchainextract.py   |   2 +-
>   elbepack/commands/validate.py           |   2 +-
>   elbepack/daemons/soap/authentication.py |   6 +-
>   elbepack/daemons/soap/esoap.py          |   5 +-
>   elbepack/daemons/soap/faults.py         |   3 +-
>   elbepack/db.py                          | 139 ++++++---------
>   elbepack/dbaction.py                    |  18 +-
>   elbepack/debianize/panels/barebox.py    |   4 +-
>   elbepack/debianize/panels/kernel.py     |   6 +-
>   elbepack/debianize/panels/uboot.py      |   6 +-
>   elbepack/debianize/widgets/button.py    |   2 +-
>   elbepack/debianize/widgets/edit.py      |   2 +-
>   elbepack/debianize/widgets/form.py      |   2 +-
>   elbepack/debinstaller.py                |  41 +++--
>   elbepack/debpkg.py                      |  21 +--
>   elbepack/dump.py                        |   8 +-
>   elbepack/efilesystem.py                 |  68 +++----
>   elbepack/egpg.py                        |  20 +--
>   elbepack/elbeproject.py                 | 228 +++++++++++-------------
>   elbepack/elbexml.py                     |  47 ++---
>   elbepack/filesystem.py                  |  12 +-
>   elbepack/finetuning.py                  | 123 ++++++-------
>   elbepack/fstab.py                       |  15 +-
>   elbepack/hashes.py                      |   8 +-
>   elbepack/hdimg.py                       | 210 +++++++++++-----------
>   elbepack/initvmaction.py                | 113 +++++-------
>   elbepack/junit.py                       |   4 +-
>   elbepack/licencexml.py                  |   2 +-
>   elbepack/log.py                         |   2 +-
>   elbepack/packers.py                     |   9 +-
>   elbepack/pbuilder.py                    |  68 +++----
>   elbepack/pbuilderaction.py              |  61 +++----
>   elbepack/pkgarchive.py                  |   2 +-
>   elbepack/pkgutils.py                    |  32 ++--
>   elbepack/projectmanager.py              |  25 ++-
>   elbepack/repodir.py                     |   3 +-
>   elbepack/repomanager.py                 |  60 +++----
>   elbepack/rfs.py                         | 102 +++++------
>   elbepack/rpcaptcache.py                 |  48 +++--
>   elbepack/shellhelper.py                 |   6 +-
>   elbepack/soapclient.py                  |  33 ++--
>   elbepack/templates.py                   |   2 +-
>   elbepack/tests/test_preproc.py          |   3 +-
>   elbepack/tests/test_pylint.py           |   9 +-
>   elbepack/tests/test_xml.py              |  22 +--
>   elbepack/treeutils.py                   |   2 +-
>   elbepack/updated.py                     |  26 ++-
>   elbepack/updated_monitors.py            |   3 +-
>   elbepack/updatepkg.py                   |  10 +-
>   elbepack/validate.py                    |   6 +-
>   elbepack/virtapt.py                     |  25 ++-
>   elbepack/xmldefaults.py                 |   2 +-
>   elbepack/xmlpreprocess.py               |  43 +++--
>   77 files changed, 957 insertions(+), 1128 deletions(-)
> 


More information about the elbe-devel mailing list