[elbe-devel] [PATCH v3 03/16] schema: copy_to_partition, set_partition_type: Add attributes

[Bastian Germann]

Am 18.10.22 um 14:12 schrieb viraj:
> 
> 
> On 10/7/22 12:51, Bastian Germann wrote:
>> Am 23.09.22 um 16:03 schrieb Viraj Shah:
>>> +    <attribute name="part" type="integer" use="required">
>>> +     <annotation>
>>> +      <documentation>
>>> +        Describes the partition to be modified in integer.
>>
>> I can see from the schema that this is an integer. What I cannot see
>> is how this integer relates to the partition.
>> Is it the partition number as understood by fdisk?
> Yes.
> When changing partition type, it asks user the partition number in case
> of many partitions, and then the type.

Then please have that in the documentation.

>>
>>> +      </documentation>
>>> +     </annotation>
>>> +    </attribute>
>>> +    <attribute name="type" type="string" use="required">
>>> +     <annotation>
>>> +      <documentation>
>>> +       Describes the numerical partition id, as understood by fdsik.
>>> +       It is the "partition type" and can be a numerical id or a
>>> textual alias
>>> +       for it. This is why the attribute type is string and not int.
>>
>> Please remove the last sentence. It is obvious.
>>
>>> +      </documentation>
>>> +     </annotation>
>>> +    </attribute>
>>>      </complexType>
>>>      <complexType name="addgroup">
>>>        <annotation>
>