[elbe-devel] [PATCH v2 02/17] schema: dbsfed.xsd: copy_from_partition

[Bastian Germann]

Am 30.08.22 um 15:39 schrieb Viraj Shah:
> Add missing attributes documentation for finetuning action
> "copy_from_partition".
> 
> Signed-off-by: Viraj Shah <viraj.shah at linutronix.de>
> ---
>   schema/dbsfed.xsd | 22 ++++++++++++++++------
>   1 file changed, 16 insertions(+), 6 deletions(-)
> 
> diff --git a/schema/dbsfed.xsd b/schema/dbsfed.xsd
> index 82acee6d9..b6c0e1e2e 100644
> --- a/schema/dbsfed.xsd
> +++ b/schema/dbsfed.xsd
> @@ -2394,16 +2394,26 @@
>     <complexType name="copy_from_partition">
>       <annotation>
>         <documentation>
> -        Attribute 'part' describes the partition to be mounted (nr).
> -	The value of the tag describes the filename to be copied from the
> -	Filesystem, after it has been mounted.
> -	Attribute 'artifact' is the artifact name.
> +	Using "copy_from partition", user gets an opportunity to copy a file
> +	from a partition and save it as an atrifact in the build output.

Please mention that the element's content is a file's path within the 'part' partition.

>         </documentation>
>       </annotation>
>       <simpleContent>
>         <extension base="rfs:string">
> -        <attribute name="part" type="integer" use="required" />
> -        <attribute name="artifact" type="string" use="required" />
> +        <attribute name="part" type="integer" use="required">
> +	 <annotation>
> +          <documentation>
> +	   Describes the partition to which the required file belongs to.
> +	  </documentation>
> +         </annotation>
> +        </attribute>
> +        <attribute name="artifact" type="string" use="required">
> +	 <annotation>
> +          <documentation>
> +	   The name of the file that needs to be extracted in termed as an "artifact".

Please remove "in termed".

> +	  </documentation>
> +         </annotation>
> +        </attribute>
>         </extension>
>       </simpleContent>
>     </complexType>

Please fix the indentation. Use only spaces even if the replaced stuff has tabs.