[elbe-devel] [PATCH] Fix bash completion support

Kaspar Giger kg at kgmw.ch
Wed Feb 8 14:20:26 CET 2023


On 20.12.22 14:22, bage at linutronix.de (Bastian Germann) wrote:
> When adding the bash completion support I renamed the bash-completion file
> to be installed in the package where the executable is located.
> Unfortunately, I tested the resulting Debian package build in the same bash
> where the completion was already loaded and did not notice it does not work
> that way.
>
> As it is not Debian-related, move the completion file out of the debian
> directory and reference it.
>


Hi Bastian, 

Thanks for the adaptations. I've tested them with a clean installation. Looks all good, behaves as expected. 

I agree with your reasoning about the moving the file out of the debian folder. Personally I wouldn't like the bash-completion script be located at the repo's top-level folder. However, you're the maintainer, therefore, I rely on your educated judgment. Funcionality is all good and therefore accepted.

Reviewed-By: Kaspar Giger <kg at kgmw.ch>


More information about the elbe-devel mailing list