[elbe-devel] [PATCH 26/37] Drop type hints

Eduard Krein eduard.krein at linutronix.de
Wed Feb 7 16:30:38 CET 2024


Am Mittwoch, dem 07.02.2024 um 15:28 +0100 schrieb Benedikt Spranger:
> Python type hints are a contradiction in terms or more clear:
> 
> "If you want static type checking, use a mature programing language."
> 
> Signed-off-by: Benedikt Spranger <b.spranger at linutronix.de>
Reviewed-by: Eduard Krein <eduard.krein at linutronix.de>
> ---
>  elbepack/aptpkgutils.py | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/elbepack/aptpkgutils.py b/elbepack/aptpkgutils.py
> index 0dee6520..c04d4ae2 100644
> --- a/elbepack/aptpkgutils.py
> +++ b/elbepack/aptpkgutils.py
> @@ -96,7 +96,6 @@ def pkgorigin(pkg):
>  
>  
>  def _file_is_same(path, size, sha256):
> -    # type: (str, int, str) -> bool
>      """Return ``True`` if the file is the same."""
>      if os.path.exists(path) and os.path.getsize(path) == size:
>          with open(path) as fobj:
> @@ -105,7 +104,6 @@ def _file_is_same(path, size, sha256):
>  
>  
>  def fetch_binary(version, destdir='', progress=None):
> -    # type: (str, AcquireProgress) -> str
>      """Fetch the binary version of the package.
>  
>      The parameter *destdir* specifies the directory where the
> package will

-- 
Eduard Krein
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 19; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy
can be found here): https://linutronix.de/legal/data-protection.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br.,HRB700
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas
Gleixner, Sharon Heck, Yulia Beck, Tiffany Silva




More information about the elbe-devel mailing list