[elbe-devel] [PATCH] logging: non-verbose tar (except for archives)

John Ogness john.ogness at linutronix.de
Wed Aug 10 15:33:01 CEST 2016


The verbose option was used on all tar commands. This could
create immense output over the soap interface and is not
necessary. The only place where the verbose option is left
enabled is when unpacking project archives. Since this is
globbering any Debian-installed files, there is real value
is including this file list in the log files

Signed-off-by: John Ogness <john.ogness at linutronix.de>
---
 elbepack/commands/init.py       | 2 +-
 elbepack/elbeproject.py         | 4 ++--
 elbepack/init/init-elbe.sh.mako | 2 +-
 elbepack/pbuilderaction.py      | 2 +-
 4 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/elbepack/commands/init.py b/elbepack/commands/init.py
index 27fcaff..0261d89 100644
--- a/elbepack/commands/init.py
+++ b/elbepack/commands/init.py
@@ -180,4 +180,4 @@ def run_command( argv ):
        os.path.join(out_path, "source.xml" ) )
 
     if opt.devel:
-        os.system ('tar cvfj "%s" -C "%s" .' % (os.path.join (out_path, "elbe-devel.tar.bz2"), elbe_dir))
+        os.system ('tar cfj "%s" -C "%s" .' % (os.path.join (out_path, "elbe-devel.tar.bz2"), elbe_dir))
diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
index da6ff28..ae97002 100644
--- a/elbepack/elbeproject.py
+++ b/elbepack/elbeproject.py
@@ -168,7 +168,7 @@ class ElbeProject (object):
         for p in paths:
             self.log.do( 'find -path "%s" >> %s' % (p, sysrootfilelist) )
 
-        self.log.do( "tar cvfJ %s/sysroot.tar.xz -C %s -T %s" %
+        self.log.do( "tar cfJ %s/sysroot.tar.xz -C %s -T %s" %
                 (self.builddir, self.chrootpath, sysrootfilelist) )
 
         # chroot is invalid after adding all the -dev packages
@@ -357,7 +357,7 @@ class ElbeProject (object):
         self.log.do ('mkdir -p "%s"' % os.path.join (pbdir))
 
         # Untar current_pdebuild.tar.gz into pdebuilder/current
-        self.log.do ('tar xvfz "%s" -C "%s"' % (os.path.join (self.builddir,
+        self.log.do ('tar xfz "%s" -C "%s"' % (os.path.join (self.builddir,
                                                   "current_pdebuild.tar.gz"),
                                                 pbdir))
 
diff --git a/elbepack/init/init-elbe.sh.mako b/elbepack/init/init-elbe.sh.mako
index dcf783d..fda531a 100644
--- a/elbepack/init/init-elbe.sh.mako
+++ b/elbepack/init/init-elbe.sh.mako
@@ -37,7 +37,7 @@ ln -s /lib/systemd/system/serial-getty at .service /buildenv/etc/systemd/system/get
 
 % if opt.devel:
    mkdir /buildenv/var/cache/elbe/devel
-   tar xvj -f elbe-devel.tar.bz2 -C /buildenv/var/cache/elbe/devel
+   tar xj -f elbe-devel.tar.bz2 -C /buildenv/var/cache/elbe/devel
    echo "export PATH=/var/cache/elbe/devel:\$PATH" > /buildenv/etc/profile.d/elbe-devel-path.sh
    sed -i s%/usr/bin/elbe%/var/cache/elbe/devel/elbe% /buildenv/etc/init.d/elbe-daemon
 % endif
diff --git a/elbepack/pbuilderaction.py b/elbepack/pbuilderaction.py
index db3962e..32f1351 100644
--- a/elbepack/pbuilderaction.py
+++ b/elbepack/pbuilderaction.py
@@ -163,7 +163,7 @@ class BuildAction(PBuilderAction):
         print ("Packing Source into tmp archive")
         print ("")
         try:
-            system ('tar cvfz "%s" .' % (tmp.fname ("pdebuild.tar.gz")))
+            system ('tar cfz "%s" .' % (tmp.fname ("pdebuild.tar.gz")))
         except CommandError:
             print ("tar Failed", file=sys.stderr)
             print ("Giving up", file=sys.stderr)
-- 
2.8.1




More information about the elbe-devel mailing list