[elbe-devel] [PATCH 08/13] elbeproject: always validate binary repos

[Manuel Traut]

On Wed, Dec 06, 2017 at 10:49:29AM +0100, Torben Hohn wrote:
> On Thu, Nov 30, 2017 at 03:15:10PM +0100, Manuel Traut wrote:
> > it makes no sense, to only validate the repos if a bin-cdrom.iso
> > should be generated. The repos are also needed to build the RFS.
> 
> I also question, why source repos shall not be validated ?
>
> if i specify a repository in the xml it must be validatet.
> no matter if i skip source building, or not.
>
> Before this ValidationMode was introduced, we had a flag,
> that would skip Repo Validation altogether.
> (This was added, because Repo Validation was not perfect, and we needed
> to be able to skip it. Considering, that we currently still cant
> validate httpredir, we need to be able to skip URL Validation. I dont
> see why we have to make distinctions here)

I'm fine with that for url-list repos. But i've no idea how to decide if it's
an error if the primary_mirror has sources or not.

> What we also should think about is how we should treat not existing
> sourcecode. (Its not correct to error out if source is not found,
> because customer app is normally not coming with source)
> 
> We should probably add semething like <pkg closed_source="1"> or
> something. so that we can produce errors, when source is not found.

That's not related with repo validation at all. Please submit a new feature
request.


> > Signed-off-by: Manuel Traut <manut at linutronix.de>
> > ---
> >  elbepack/elbeproject.py | 8 +++-----
> >  1 file changed, 3 insertions(+), 5 deletions(-)
> > 
> > diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
> > index f120ccc5..2232b4c1 100644
> > --- a/elbepack/elbeproject.py
> > +++ b/elbepack/elbeproject.py
> > @@ -207,11 +207,9 @@ class ElbeProject (object):
> >          self.write_log_header()
> >  
> >          # Validate Apt Sources
> > -        m = ValidationMode.NO_CHECK
> > -        if build_bin:
> > -            m = ValidationMode.CHECK_BINARIES
> > -            if build_sources:
> > -                m = ValidationMode.CHECK_ALL
> > +        m = ValidationMode.CHECK_BINARIES
> > +        if build_sources:
> > +            m = ValidationMode.CHECK_ALL
> >          self.xml.validate_apt_sources ( m , self.arch )
> >  
> >  
> > -- 
> > 2.15.1
> > 
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Mit freundlichen Grüßen
> Torben Hohn
> 
> Linutronix GmbH
> 
> Standort: Bremen
> 
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
> Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
> Nr. / Trade register no.: 700 806
> 
> Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner
> 
> Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
> benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
> möglich ist, durch Antwort-Mail. Vielen Dank!