[elbe-devel] [PATCH 11/13] soapclient: print success not to stderr

[Manuel Traut]

On Tue, Dec 05, 2017 at 05:11:21PM +0100, Torben Hohn wrote:
> 
> i am not so happy with this.
> Seems to be okay.
> 
> But since `elbe control` is used in backticks somtimes, we must
> be careful with stdout.
> 
> Its probably ok, where files are saved.
> Please say, why its a problem, when it goes to stderr ?

It's decided behaviour that the files are saved. So it shouldn't be interpreted
as an error. Eg. if you do unit testing it will be logged as error in the XML.

If you need another behaviour we should add a '--verbose' '--script' or whatever
parameter. If you really need it --> feature request.

> On Thu, Nov 30, 2017 at 03:15:13PM +0100, Manuel Traut wrote:
> > Signed-off-by: Manuel Traut <manut at linutronix.de>
> > ---
> >  elbepack/soapclient.py | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/elbepack/soapclient.py b/elbepack/soapclient.py
> > index 835e9e6d..d5a15d7e 100644
> > --- a/elbepack/soapclient.py
> > +++ b/elbepack/soapclient.py
> > @@ -340,7 +340,7 @@ class GetFileAction(ClientAction):
> >              dst_fname = str (os.path.join (dst, filename))
> >  
> >          client.download_file (builddir, filename, dst_fname)
> > -        print (dst_fname + " saved", file=sys.stderr)
> > +        print("%s saved" % dst_fname)
> >  
> >  ClientAction.register(GetFileAction)
> >  
> > @@ -668,7 +668,7 @@ class DownloadAction(RepoAction):
> >          dst_fname = os.path.join(".", "elbe-projectrepo-" + datetime.now().strftime("%Y%m%d-%H%M%S") + ".tar.gz")
> >  
> >          client.download_file (builddir, filename, dst_fname)
> > -        print (dst_fname + " saved", file=sys.stderr)
> > +        print("%s saved" % dst_fname)
> >  
> >  
> >  RepoAction.register(DownloadAction)
> > -- 
> > 2.15.1
> > 
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Mit freundlichen Grüßen
> Torben Hohn
> 
> Linutronix GmbH
> 
> Standort: Bremen
> 
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
> Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
> Nr. / Trade register no.: 700 806
> 
> Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner
> 
> Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
> benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
> möglich ist, durch Antwort-Mail. Vielen Dank!