[elbe-devel] [PATCH] dump: remove 2nd extract of archive

[John Ogness]

On 2017-12-07, Manuel Traut <manuel.traut at linutronix.de> wrote:
>> Originally archive extraction occurred only after the finetuning step.
>> With commit 33d0e328b74d ("extract archive before finetuning to be
>> able to use the files.") extraction was added before the finetuning
>> step to allow finetuning to use archive files. However, the extraction
>> after finetuning was never removed. This dramatically reduces the
>> benefits of finetuning being able to manipulate the archive files.
>> 
>> Remove archive extraction after the finetuning step.
>> 
>> Update the logic to determine file origins in the elbe report
>> based on this new ordering.
>
> Thanks, this is a change that was requested a few times.
>
> However, this might brake image builds that (accidently) delete files in
> finetuning that are in the archive and expect them to be in the RFS.

Nothing in finetuning should be accidental.

Rather than making the pre-finetuning extract nearly useless in order to
"help" users with broken finetuning rules, I think it would make more
sense to add a warning (or error!) that a fine-tuning rule deleted a
file from the archive. This would be trivial to implement. I'm happy to
provide a patch for this.

> I'm fine if we introduce a attribute for the archive tag.
>
> <archive extraction='after_finetuning|before_finetuning'>

In my opinion extracting after finetuning is wrong. I cannot think of
any case where I want to blindly unpack files *after* I've done
customizing.

Let's fix elbe instead of finding reasons to keep it broken.

John Ogness