[elbe-devel] [PATCH 04/13] use pinning preferences also on incremental builds

Manuel Traut manuel.traut at linutronix.de
Fri Dec 8 15:06:12 CET 2017


On Tue, Dec 05, 2017 at 04:24:09PM +0100, Torben Hohn wrote:
> On Thu, Nov 30, 2017 at 03:15:06PM +0100, Manuel Traut wrote:
> > Currently pinning works only correctly for an initial image build.
> > 
> > If an incremental build is done, the pinning is not effective, because
> >   it is set inside the debootstrap path.
> > 
> > Configure pinning from the BuildEnv constructor to enable it for both
> > cases.
> > 
> > This fixes github issue #119
> > 
> > Signed-off-by: Manuel Traut <manut at linutronix.de>
> 
> Reviewed-by: Torben Hohn <torbenh at linutronix.de>

thanks for the review, applied to devel/elbe-3.0

> > ---
> >  elbepack/rfs.py | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/elbepack/rfs.py b/elbepack/rfs.py
> > index 8dc3bed1..2fa8f1a4 100644
> > --- a/elbepack/rfs.py
> > +++ b/elbepack/rfs.py
> > @@ -55,6 +55,7 @@ class BuildEnv ():
> >              self.need_dumpdebootstrap = False
> >  
> >          self.initialize_dirs (build_sources=build_sources)
> > +        self.create_apt_prefs ()
> >  
> >      def cdrom_umount(self):
> >          if self.xml.prj.has ("mirror/cdrom"):
> > @@ -107,8 +108,6 @@ class BuildEnv ():
> >  
> >          self.log.h2( "debootstrap log" )
> >  
> > -        self.create_apt_prefs ()
> > -
> >          arch = self.xml.text ("project/buildimage/arch", key="arch")
> >  
> >          host_arch = self.log.get_command_out(
> > -- 
> > 2.15.1
> > 
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Mit freundlichen Grüßen
> Torben Hohn
> 
> Linutronix GmbH
> 
> Standort: Bremen
> 
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
> Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
> Nr. / Trade register no.: 700 806
> 
> Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner
> 
> Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
> benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
> möglich ist, durch Antwort-Mail. Vielen Dank!





More information about the elbe-devel mailing list