[elbe-devel] [PATCH 10/13] soapclient: remove rm calls

Manuel Traut manuel.traut at linutronix.de
Fri Dec 8 15:07:09 CET 2017


On Tue, Dec 05, 2017 at 04:58:27PM +0100, Torben Hohn wrote:
> On Thu, Nov 30, 2017 at 03:15:12PM +0100, Manuel Traut wrote:
> > rm is not implemented. However i'm not sure if it's a good idea to
> > implement it. So let's just keep the files inside the initvm.
> > They will be deleted if the project gets removed.
> > 
> > Signed-off-by: Manuel Traut <manut at linutronix.de>
> 
> Reviewed-by: Torben Hohn <torbenh at linutronix.de>

thanks for the review, applied to devel/elbe-3.0

> > ---
> >  elbepack/soapclient.py | 8 --------
> >  1 file changed, 8 deletions(-)
> > 
> > diff --git a/elbepack/soapclient.py b/elbepack/soapclient.py
> > index 9832be87..835e9e6d 100644
> > --- a/elbepack/soapclient.py
> > +++ b/elbepack/soapclient.py
> > @@ -670,9 +670,6 @@ class DownloadAction(RepoAction):
> >          client.download_file (builddir, filename, dst_fname)
> >          print (dst_fname + " saved", file=sys.stderr)
> >  
> > -        client.service.rm (builddir, filename)
> > -        print (filename + " deleted on initvm.")
> > -
> >  
> >  RepoAction.register(DownloadAction)
> >  
> > @@ -753,9 +750,4 @@ class UploadPackageAction(RepoAction):
> >          client.service.include_package(builddir, filename)
> >  
> >  
> > -        print("Cleaning initvm builddir...")
> > -        for f in files:
> > -            client.service.rm (builddir, f)
> > -
> > -
> >  RepoAction.register(UploadPackageAction)
> > -- 
> > 2.15.1
> > 
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Mit freundlichen Grüßen
> Torben Hohn
> 
> Linutronix GmbH
> 
> Standort: Bremen
> 
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
> Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
> Nr. / Trade register no.: 700 806
> 
> Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner
> 
> Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
> benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
> möglich ist, durch Antwort-Mail. Vielen Dank!





More information about the elbe-devel mailing list