[elbe-devel] elbe initvm attach -> login does not work after upgrading from 1.1 to 1.2 stable

[Manuel Traut]

Hi Lukasz,

On Tue, Dec 12, 2017 at 04:40:05PM +0000, Lukasz Walewski wrote:
> >-----Ursprüngliche Nachricht-----
> >Von: Manuel Traut [mailto:manuel.traut at linutronix.de]
> >Gesendet: Montag, 6. November 2017 16:48
> >An: Lukasz Walewski
> >Cc: elbe-devel at linutronix.de
> >Betreff: Re: [elbe-devel] elbe initvm attach -> login does not work
> >after upgrading from 1.1 to 1.2 stable
> >
> >Hi Lukasz,
> >
> >On Fri, Sep 08, 2017 at 02:54:26PM +0000, Lukasz Walewski wrote:
> >> Hi,
> >>
> >> I think Frank meant Debian 9.0 (stretch) here. Under Debian 8.9
> >(jessie) the fix does not work. I upgraded my jessie VMware VM today,
> >which included Elbe upgrade to version 2.1 (from
> >http://debian.linutronix.de/elbe jessie main). Creating a fresh initvm
> >results in an error:
> >>
> >> $ elbe --version
> >> elbe v2.1 debian 8.9
> >>
> >> $ elbe initvm create
> >> [...]
> >> touch .stamps/stamp-create-buildenv-img
> >> /usr/bin/kvm
> >> qemu-system-x86_64: -M pc-i440fx-2.6: Unsupported machine type
> >> Use -machine help to list supported machines!
> >>
> >> So obviously the pc-i440fx-2.6 is not available in jessie, however, it
> >is requested by the Makefile if running under VMware:
> >>
> >> $ cat initvm/Makefile
> >> MEMSIZE?=1024
> >> SMP?=`nproc`
> >> INTERPRETER?=/usr/bin/kvm
> >>
> >> # this is a workaround for
> >> # http://lists.linutronix.de/pipermail/elbe-devel/2017-
> >July/000541.html
> >> VIRT=$(shell test -x /usr/bin/systemd-detect-virt && /usr/bin/systemd-
> >detect-virt)
> >> ifeq ($(VIRT), vmware)
> >> MACHINE?=pc-i440fx-2.6
> >> else
> >> MACHINE?=pc
> >> endif
> >>
> >> Wasn't this workaround meant for stretch and not for jessie?
> >
> >probably yes. I don't have a test setup for this.
> >Can you add a check for
> >
> >'lsb_release -c' == stretch
> >
> >to the Makefile.mako. And provide a patch for this?
> 
> Please find attached the requested patch. I tested it on the current Debian 8.x (stretch) with elbe v2.2, which makes kvm to boot as expected:

Thanks for the patch. It looks sane. Can you post it with an author, commit
message etc. that i can import it?

Thanks,

  Manuel