[elbe-devel] [PATCH] remove #!/usr/bin/env python from unexecutable files

John Ogness john.ogness at linutronix.de
Fri Dec 22 15:43:53 CET 2017


Hi Manuel,

While reviewing this patch I noticed that setup.py does not have the
executable bit set. If it isn't going to be executable, then the #! can
be removed from that file as well.

On 2017-12-20, Manuel Traut <manut at linutronix.de> wrote:
> a lot of files start with '#!/usr/bin/env python' however they are not
> written to be executable python scripts. Some of them even have the
> exectuable flag set.
>
> Remove the executable flag and remove '#!/usr/bin/env python' from the
> head of these files.
>
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: John Ogness <john.ogness at linutronix.de>

>
> ---
> changes since v1:
>
>  * also update files in elbepack/debianize
> ---
>  elbepack/asciidoclog.py            | 2 --
>  elbepack/asyncworker.py            | 2 --
>  elbepack/commands/add.py           | 2 --
>  elbepack/commands/bootup-check.py  | 2 --
>  elbepack/commands/buildchroot.py   | 2 --
>  elbepack/commands/chg_archive.py   | 2 --
>  elbepack/commands/control.py       | 2 --
>  elbepack/commands/db.py            | 2 --
>  elbepack/commands/debianize.py     | 2 --
>  elbepack/commands/gen_update.py    | 2 --
>  elbepack/commands/get_archive.py   | 2 --
>  elbepack/commands/hdimg.py         | 2 --
>  elbepack/commands/init.py          | 2 --
>  elbepack/commands/initvm.py        | 0
>  elbepack/commands/pbuilder.py      | 0
>  elbepack/commands/pin_versions.py  | 2 --
>  elbepack/commands/prjrepo.py       | 2 --
>  elbepack/commands/setsel.py        | 2 --
>  elbepack/commands/show.py          | 2 --
>  elbepack/commands/updated.py       | 2 --
>  elbepack/commands/xsdtoasciidoc.py | 2 --
>  elbepack/daemons/soap/esoap.py     | 2 --
>  elbepack/db.py                     | 2 --
>  elbepack/dbaction.py               | 2 --
>  elbepack/debianize/barebox.py      | 2 --
>  elbepack/debianize/base.py         | 2 --
>  elbepack/debianize/debianize.py    | 2 --
>  elbepack/debianize/kernel.py       | 2 --
>  elbepack/debianize/uboot.py        | 2 --
>  elbepack/dosunix.py                | 3 ---
>  elbepack/elbeproject.py            | 2 --
>  elbepack/gpg.py                    | 2 --
>  elbepack/initvmaction.py           | 2 --
>  elbepack/pbuilderaction.py         | 2 --
>  elbepack/pkgarchive.py             | 2 --
>  elbepack/projectmanager.py         | 2 --
>  elbepack/soapclient.py             | 2 --
>  elbepack/updated.py                | 2 --
>  elbepack/updated_monitors.py       | 2 --
>  elbepack/updatepkg.py              | 2 --
>  elbepack/version.py                | 2 --
>  41 files changed, 79 deletions(-)
>  mode change 100755 => 100644 elbepack/commands/bootup-check.py
>  mode change 100755 => 100644 elbepack/commands/control.py
>  mode change 100755 => 100644 elbepack/commands/initvm.py
>  mode change 100755 => 100644 elbepack/commands/pbuilder.py
>  mode change 100755 => 100644 elbepack/commands/prjrepo.py
>  mode change 100755 => 100644 elbepack/dosunix.py
>
> diff --git a/elbepack/asciidoclog.py b/elbepack/asciidoclog.py
> index 93095a8c..fcab65ea 100644
> --- a/elbepack/asciidoclog.py
> +++ b/elbepack/asciidoclog.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/asyncworker.py b/elbepack/asyncworker.py
> index ac9eb273..e43a71d1 100644
> --- a/elbepack/asyncworker.py
> +++ b/elbepack/asyncworker.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/add.py b/elbepack/commands/add.py
> index 16810b3c..0bd1bd9a 100644
> --- a/elbepack/commands/add.py
> +++ b/elbepack/commands/add.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/bootup-check.py b/elbepack/commands/bootup-check.py
> old mode 100755
> new mode 100644
> index d63cc0cc..8d3ffcde
> --- a/elbepack/commands/bootup-check.py
> +++ b/elbepack/commands/bootup-check.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/buildchroot.py b/elbepack/commands/buildchroot.py
> index 19837ea6..c65c9e83 100644
> --- a/elbepack/commands/buildchroot.py
> +++ b/elbepack/commands/buildchroot.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/chg_archive.py b/elbepack/commands/chg_archive.py
> index c0c148f1..860dc1b1 100644
> --- a/elbepack/commands/chg_archive.py
> +++ b/elbepack/commands/chg_archive.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/control.py b/elbepack/commands/control.py
> old mode 100755
> new mode 100644
> index ea03d268..e0cde25b
> --- a/elbepack/commands/control.py
> +++ b/elbepack/commands/control.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014,2017 Linutronix GmbH
>  #
> diff --git a/elbepack/commands/db.py b/elbepack/commands/db.py
> index 91bdfcf3..166dc46d 100644
> --- a/elbepack/commands/db.py
> +++ b/elbepack/commands/db.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/debianize.py b/elbepack/commands/debianize.py
> index ecc36f39..3f80d17a 100644
> --- a/elbepack/commands/debianize.py
> +++ b/elbepack/commands/debianize.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/gen_update.py b/elbepack/commands/gen_update.py
> index bcae057c..26d28193 100644
> --- a/elbepack/commands/gen_update.py
> +++ b/elbepack/commands/gen_update.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/get_archive.py b/elbepack/commands/get_archive.py
> index ec0da856..1129e732 100644
> --- a/elbepack/commands/get_archive.py
> +++ b/elbepack/commands/get_archive.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/hdimg.py b/elbepack/commands/hdimg.py
> index 1f0764c1..fd513878 100644
> --- a/elbepack/commands/hdimg.py
> +++ b/elbepack/commands/hdimg.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/init.py b/elbepack/commands/init.py
> index 6700d49b..ceaadd7f 100644
> --- a/elbepack/commands/init.py
> +++ b/elbepack/commands/init.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/initvm.py b/elbepack/commands/initvm.py
> old mode 100755
> new mode 100644
> diff --git a/elbepack/commands/pbuilder.py b/elbepack/commands/pbuilder.py
> old mode 100755
> new mode 100644
> diff --git a/elbepack/commands/pin_versions.py b/elbepack/commands/pin_versions.py
> index f8a28ca8..e4bdf671 100644
> --- a/elbepack/commands/pin_versions.py
> +++ b/elbepack/commands/pin_versions.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/prjrepo.py b/elbepack/commands/prjrepo.py
> old mode 100755
> new mode 100644
> index 6ac7abc0..0296077b
> --- a/elbepack/commands/prjrepo.py
> +++ b/elbepack/commands/prjrepo.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2017  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/setsel.py b/elbepack/commands/setsel.py
> index 26f17507..9c2648d0 100644
> --- a/elbepack/commands/setsel.py
> +++ b/elbepack/commands/setsel.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/show.py b/elbepack/commands/show.py
> index 00df63ff..deac7cef 100644
> --- a/elbepack/commands/show.py
> +++ b/elbepack/commands/show.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/commands/updated.py b/elbepack/commands/updated.py
> index 0eb25b6b..6e8b1f1b 100644
> --- a/elbepack/commands/updated.py
> +++ b/elbepack/commands/updated.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  # Copyright (C) 2015  emtrion GmbH
> diff --git a/elbepack/commands/xsdtoasciidoc.py b/elbepack/commands/xsdtoasciidoc.py
> index ec3e172e..99ef2107 100644
> --- a/elbepack/commands/xsdtoasciidoc.py
> +++ b/elbepack/commands/xsdtoasciidoc.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
> index b5ecbdfc..2348be44 100644
> --- a/elbepack/daemons/soap/esoap.py
> +++ b/elbepack/daemons/soap/esoap.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/db.py b/elbepack/db.py
> index 332c5276..a09c4443 100644
> --- a/elbepack/db.py
> +++ b/elbepack/db.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/dbaction.py b/elbepack/dbaction.py
> index 52dee742..21e272a4 100644
> --- a/elbepack/dbaction.py
> +++ b/elbepack/dbaction.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/debianize/barebox.py b/elbepack/debianize/barebox.py
> index 46fdeed1..1648158b 100644
> --- a/elbepack/debianize/barebox.py
> +++ b/elbepack/debianize/barebox.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/debianize/base.py b/elbepack/debianize/base.py
> index 71948001..04dbc070 100644
> --- a/elbepack/debianize/base.py
> +++ b/elbepack/debianize/base.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/debianize/debianize.py b/elbepack/debianize/debianize.py
> index 2db30b0c..47a1a393 100644
> --- a/elbepack/debianize/debianize.py
> +++ b/elbepack/debianize/debianize.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/debianize/kernel.py b/elbepack/debianize/kernel.py
> index 527c47ed..186a56e5 100644
> --- a/elbepack/debianize/kernel.py
> +++ b/elbepack/debianize/kernel.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/debianize/uboot.py b/elbepack/debianize/uboot.py
> index 65c30986..c2175a51 100644
> --- a/elbepack/debianize/uboot.py
> +++ b/elbepack/debianize/uboot.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #
> diff --git a/elbepack/dosunix.py b/elbepack/dosunix.py
> old mode 100755
> new mode 100644
> index bb677131..c8c06e26
> --- a/elbepack/dosunix.py
> +++ b/elbepack/dosunix.py
> @@ -1,6 +1,3 @@
> -#!/usr/bin/env python
> -
> -
>  def dos2unix_str (d):
>      return d.replace('\r\n', '\n')
>  
> diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
> index fc4bc412..84c0da31 100644
> --- a/elbepack/elbeproject.py
> +++ b/elbepack/elbeproject.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/gpg.py b/elbepack/gpg.py
> index 0ea42be9..085fc0eb 100644
> --- a/elbepack/gpg.py
> +++ b/elbepack/gpg.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
> index 12bb3b54..8dc87ded 100644
> --- a/elbepack/initvmaction.py
> +++ b/elbepack/initvmaction.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/pbuilderaction.py b/elbepack/pbuilderaction.py
> index 53963931..0c77ca3c 100644
> --- a/elbepack/pbuilderaction.py
> +++ b/elbepack/pbuilderaction.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/pkgarchive.py b/elbepack/pkgarchive.py
> index b8a79ff9..2ecd8afa 100644
> --- a/elbepack/pkgarchive.py
> +++ b/elbepack/pkgarchive.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/projectmanager.py b/elbepack/projectmanager.py
> index a747de0c..df8eed48 100644
> --- a/elbepack/projectmanager.py
> +++ b/elbepack/projectmanager.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/soapclient.py b/elbepack/soapclient.py
> index 607f551d..dd16be6a 100644
> --- a/elbepack/soapclient.py
> +++ b/elbepack/soapclient.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013  Linutronix GmbH
>  #
> diff --git a/elbepack/updated.py b/elbepack/updated.py
> index d984595d..4d425d42 100644
> --- a/elbepack/updated.py
> +++ b/elbepack/updated.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2015 emtrion GmbH
>  # Copyright (C) 2014  Linutronix GmbH
> diff --git a/elbepack/updated_monitors.py b/elbepack/updated_monitors.py
> index 4fc80761..9e4c4569 100644
> --- a/elbepack/updated_monitors.py
> +++ b/elbepack/updated_monitors.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2015 emtrion GmbH
>  # Copyright (C) 2014  Linutronix GmbH
> diff --git a/elbepack/updatepkg.py b/elbepack/updatepkg.py
> index cb3afeba..983fb807 100644
> --- a/elbepack/updatepkg.py
> +++ b/elbepack/updatepkg.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2013, 2014  Linutronix GmbH
>  #
> diff --git a/elbepack/version.py b/elbepack/version.py
> index 9b659072..06882520 100644
> --- a/elbepack/version.py
> +++ b/elbepack/version.py
> @@ -1,5 +1,3 @@
> -#!/usr/bin/env python
> -#
>  # ELBE - Debian Based Embedded Rootfilesystem Builder
>  # Copyright (C) 2016  Linutronix GmbH
>  #

-- 
Phone: +49 7556 25 999 20; Fax.: +49 7556 25 999 99

Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
Nr. / Trade register no.: 700 806

Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner

Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
möglich ist, durch Antwort-Mail. Vielen Dank!



More information about the elbe-devel mailing list