[elbe-devel] [PATCH 0/6 v5] use SPDX identifiers in ELBE

Kate Stewart kstewart at linuxfoundation.org
Fri Apr 13 02:06:13 CEST 2018


Hi Manuel,
     Feel free to add my:
Reviewed-by: Kate Stewart <kstewart at linuxfoundation.org>

Copyrights and SPDX identifiers look much better.  :-)

I don't think you need to add the info to a .gitignore file,
(Patch 4/6),  but not sure its worth respinning the patchset over.

Kate

On Mon, Apr 9, 2018 at 1:12 PM, Manuel Traut <manut at linutronix.de> wrote:

> Hi Kate,
>
> this is a rework of my ELBE/SPDX queue. It includes your suggestions about
> the copyright statements and includes the current version of the
> identifiers.
>
> Thanks for your help!
>
>   Manuel
>
> changes since v1:
>
>  * spdx headers were missed in 2 files, these are added in v2:
>     - commands/adjustpkgs.py
>     - commands/updatepkg.py
>
> changes since v2:
>
>  * don't add copyright statements to files that had none before
>      (contrib/dockerfile)
>  * use GPL-3.0+ instead of GPL-3.0
>  * use SPDX and Debian Identifier in debian/copyright, remove the license
> tags
>      and reference to /usr/share/common-licenses/GPL-3
>  * the license text in COPYING doesn't need to be changed, it covers
> GPL-3.0
>      and GPL-3.0+
>
> changes since v3:
>
>   * mention licensing rules in README.adoc
>
> changes since v4:
>
>   * use current identifiers (e.g. GPL-2.0-only instead of GPL-2.0)
>   * extract correct copyright statement from git and include in the file
> header
>   * add copyright and license informations for
>      - docs/Makefile
>      - .pylintrc
>      - .gitignore
>
> Manuel Traut (6):
>   use SPDX tags in headers
>   README: add section about license rules
>   add SPDX tags to contrib/dockerfile/*
>   add copyright and license notes to .gitignore file
>   add copyright and license notes to .pylintrc file
>   add license and copyright information to docs/Makefile
>
>  .gitignore                                    |  6 ++++
>  .pylintrc                                     |  6 ++++
>  Makefile                                      |  5 ++++
>  README.adoc                                   | 28 +++++++++++++++++++
>  contrib/dockerfile/Dockerfile                 |  8 +++++-
>  contrib/dockerfile/Makefile                   |  5 ++++
>  contrib/dockerfile/README.md                  |  7 ++++-
>  contrib/dockerfile/adds/supervisord.conf      |  1 +
>  debian/copyright                              | 28 ++++---------------
>  docs/Makefile                                 |  7 +++++
>  docs/build-example-doc.sh                     |  5 ++++
>  elbe                                          | 20 ++++---------
>  elbepack/aptpkgutils.py                       | 19 +++----------
>  elbepack/aptprogress.py                       | 18 ++----------
>  elbepack/asciidoclog.py                       | 19 +++----------
>  elbepack/asyncworker.py                       | 19 +++----------
>  elbepack/cdroms.py                            | 20 ++++---------
>  elbepack/commands/add.py                      | 17 ++---------
>  elbepack/commands/adjustpkgs.py               | 18 ++----------
>  elbepack/commands/bootup-check.py             | 17 ++---------
>  elbepack/commands/buildchroot.py              | 20 ++++---------
>  elbepack/commands/buildsdk.py                 |  4 +--
>  elbepack/commands/buildsysroot.py             | 19 +++----------
>  elbepack/commands/check_updates.py            | 19 +++----------
>  elbepack/commands/chg_archive.py              | 17 ++---------
>  elbepack/commands/chroot.py                   | 20 ++++---------
>  elbepack/commands/control.py                  | 19 +++----------
>  elbepack/commands/daemon.py                   | 17 ++---------
>  elbepack/commands/db.py                       | 17 ++---------
>  elbepack/commands/debianize.py                | 18 ++----------
>  elbepack/commands/diff.py                     | 17 ++---------
>  elbepack/commands/gen_update.py               | 20 ++++---------
>  elbepack/commands/genlicence.py               | 18 ++----------
>  elbepack/commands/get_archive.py              | 18 ++----------
>  elbepack/commands/hdimg.py                    | 19 +++----------
>  elbepack/commands/init.py                     | 19 +++----------
>  elbepack/commands/initvm.py                   | 18 ++----------
>  elbepack/commands/mkcdrom.py                  | 20 ++++---------
>  elbepack/commands/parselicence.py             | 18 ++----------
>  elbepack/commands/pbuilder.py                 | 18 ++----------
>  elbepack/commands/pin_versions.py             | 18 ++----------
>  elbepack/commands/pkgdiff.py                  | 19 +++----------
>  elbepack/commands/preprocess.py               | 18 ++----------
>  elbepack/commands/prjrepo.py                  | 19 +++----------
>  elbepack/commands/remove_sign.py              | 22 ++-------------
>  elbepack/commands/setsel.py                   | 18 ++----------
>  elbepack/commands/show.py                     | 18 ++----------
>  elbepack/commands/sign.py                     | 18 ++----------
>  elbepack/commands/toolchainextract.py         | 18 ++----------
>  elbepack/commands/updated.py                  | 20 +++----------
>  elbepack/commands/validate.py                 | 18 ++----------
>  elbepack/commands/xsdtoasciidoc.py            | 18 ++----------
>  elbepack/config.py                            | 20 +++----------
>  elbepack/daemons/soap/__init__.py             | 18 ++----------
>  elbepack/daemons/soap/authentication.py       | 20 ++-----------
>  elbepack/daemons/soap/datatypes.py            | 19 ++-----------
>  elbepack/daemons/soap/esoap.py                | 20 ++++---------
>  elbepack/daemons/soap/faults.py               | 18 ++----------
>  elbepack/db.py                                | 20 ++++---------
>  elbepack/dbaction.py                          | 19 +++----------
>  elbepack/debianize/barebox.py                 | 18 ++----------
>  elbepack/debianize/base.py                    | 19 +++----------
>  elbepack/debianize/debianize.py               | 17 ++---------
>  elbepack/debianize/kernel.py                  | 19 +++----------
>  elbepack/debianize/uboot.py                   | 18 ++----------
>  elbepack/debianreleases.py                    | 18 ++----------
>  elbepack/debpkg.py                            | 18 ++----------
>  elbepack/directories.py                       | 19 +++----------
>  elbepack/dump.py                              | 19 +++----------
>  elbepack/efilesystem.py                       | 21 ++++----------
>  elbepack/elbeproject.py                       | 22 +++++----------
>  elbepack/elbexml.py                           | 22 +++++----------
>  elbepack/filesystem.py                        | 19 ++-----------
>  elbepack/finetuning.py                        | 20 ++++---------
>  elbepack/fstab.py                             | 19 +++----------
>  elbepack/gpg.py                               | 19 +++----------
>  elbepack/hdimg.py                             | 21 ++++----------
>  elbepack/init/Makefile.mako                   | 19 +++----------
>  elbepack/init/apt.conf.mako                   | 16 ++---------
>  elbepack/init/init-elbe.sh.mako               | 19 +++----------
>  elbepack/init/libvirt.xml.mako                |  6 ++++
>  elbepack/init/preseed.cfg.mako                | 19 +++----------
>  elbepack/initvmaction.py                      | 22 +++++----------
>  elbepack/kvm.py                               | 19 +++----------
>  elbepack/licencexml.py                        | 20 ++-----------
>  .../makofiles/debianize/barebox/control.mako  |  6 ++++
>  .../makofiles/debianize/barebox/format.mako   |  6 ++++
>  .../makofiles/debianize/barebox/rules.mako    |  6 ++++
>  .../makofiles/debianize/kernel/control.mako   |  7 +++++
>  .../makofiles/debianize/kernel/format.mako    |  5 ++++
>  .../makofiles/debianize/kernel/postinst.mako  |  6 ++++
>  .../makofiles/debianize/kernel/postrm.mako    |  6 ++++
>  .../makofiles/debianize/kernel/preinst.mako   |  6 ++++
>  .../makofiles/debianize/kernel/prerm.mako     |  6 ++++
>  .../makofiles/debianize/kernel/rules.mako     |  8 ++++++
>  elbepack/makofiles/preferences.mako           | 19 +++----------
>  elbepack/pbuilder.py                          |  7 +++++
>  elbepack/pbuilderaction.py                    | 18 ++----------
>  elbepack/pkgarchive.py                        | 18 ++----------
>  elbepack/pkgutils.py                          | 19 +++----------
>  elbepack/projectmanager.py                    | 21 ++++----------
>  elbepack/repomanager.py                       | 21 ++++----------
>  elbepack/rfs.py                               | 21 ++++----------
>  elbepack/rpcaptcache.py                       | 20 ++++---------
>  elbepack/shellhelper.py                       | 19 +++----------
>  elbepack/soapclient.py                        | 20 ++++---------
>  elbepack/templates.py                         | 18 ++----------
>  elbepack/toolchain.py                         | 18 ++----------
>  elbepack/treeutils.py                         | 18 ++----------
>  elbepack/updated.py                           | 23 +++++----------
>  elbepack/updated_monitors.py                  | 19 ++-----------
>  elbepack/updatepkg.py                         | 18 ++----------
>  elbepack/validate.py                          | 19 +++----------
>  elbepack/version.py                           | 18 ++----------
>  elbepack/virtapt.py                           | 20 ++++---------
>  elbepack/xmldefaults.py                       |  7 +++++
>  elbepack/xmlpreprocess.py                     | 18 ++----------
>  elbepack/xsdtoasciidoc.mako                   |  5 ++++
>  elbepack/ziparchives.py                       | 19 ++-----------
>  setup.py                                      |  6 ++++
>  test/updated.py                               |  6 ++++
>  121 files changed, 534 insertions(+), 1437 deletions(-)
>
> --
> 2.17.0
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180412/809639ca/attachment-0001.html>


More information about the elbe-devel mailing list