[elbe-devel] [PATCH 00/25] first part of pylint fixes patchqueue

[Torben Hohn]

pylint commandline used here:

---------------------------------------------------------------------------
pylint -f parseable \
       --extension-pkg-whitelist=apt_pkg,gpgme,lxml.etree,_ped \
       --generated-members=gpgme.SIGSUM_*,gpgme.SIG_MODE_NORMAL \
       "$@"
---------------------------------------------------------------------------

This patchqueue fixes quite a lot pylint warnings.

-----------------------------------------------------------------------
Messages by category
--------------------

+-----------+-------+---------+-----------+
|type       |number |previous |difference |
+===========+=======+=========+===========+
|convention |40     |113      |-73.00     |
+-----------+-------+---------+-----------+
|refactor   |129    |261      |-132.00    |
+-----------+-------+---------+-----------+
|warning    |169    |309      |-140.00    |
+-----------+-------+---------+-----------+
|error      |23     |98       |-75.00     |
+-----------+-------+---------+-----------+
-----------------------------------------------------------------------

aaand... there is more in the pipe.


Torben Hohn (25):
  pylint: cdroms: remove unused variables
  pylint: cdroms: group apt imports together
  pylint: shellhelper: rename input parameter to stdin
  pylint: config: call baseclass.__init__() in Config.__init__()
  pylint: initvmaction: remove unused wdfs global variable and parameter
  pylint: pbuilderaction: remove unused wdfs argument and import
  pylint: initvmaction: reformat cmd_exists, so that pylint doe not
    complain
  pylint: initvmaction: remove unnecessary parenthesis
  pylint: elbeproject: add missing import sys
  pylint: elbeproject: remove unused imported symbol "template"
  pylint: elbeproject: remove unnecessary parenthesis
  pylint: fix unused args and unused vars
  pylint: daemons soap: remove unused "example" code in
    MySession.__call__()
  pylint: annotate functions triggerring too-many-* messages
  pylint: shellhelper: call command_out_stderr() in system_out_stderr()
  pylint: disable too-many-instance variables
  pylint: initvmaction: fix import order
  pylint: daemons soap: __init__() ESoap with self.app and
    self.transport
  pylint: add abstract methods for "action" interfaces
  pylint: fstab: setup geometry in new function, and init attrs in
    __init__()
  pylint: locally disable no-member complaints
  pylint: toolchain: move class attributes to the classes using them
  pylint: updated: init self.app in __init__()
  pylint: fixup import order so that pylint stops complaining
  pylint: more import order fixes

 elbepack/aptpkgutils.py                 |  5 +++
 elbepack/aptprogress.py                 |  3 +-
 elbepack/archivedir.py                  |  4 +-
 elbepack/asciidoclog.py                 |  8 ++--
 elbepack/asyncworker.py                 | 17 +++++----
 elbepack/cdroms.py                      | 36 +++++++++++-------
 elbepack/commands/add.py                |  4 +-
 elbepack/commands/adjustpkgs.py         |  7 ++--
 elbepack/commands/check_updates.py      |  7 +++-
 elbepack/commands/chg_archive.py        |  3 +-
 elbepack/commands/control.py            |  7 +++-
 elbepack/commands/daemon.py             | 11 +++---
 elbepack/commands/debianize.py          |  2 +-
 elbepack/commands/diff.py               |  5 +--
 elbepack/commands/gen_update.py         |  3 ++
 elbepack/commands/get_archive.py        |  4 +-
 elbepack/commands/init.py               |  8 +++-
 elbepack/commands/mkcdrom.py            |  3 ++
 elbepack/commands/parselicence.py       |  5 ++-
 elbepack/commands/pin_versions.py       |  3 +-
 elbepack/commands/pkgdiff.py            |  6 ++-
 elbepack/commands/prjrepo.py            |  6 ++-
 elbepack/commands/setsel.py             |  5 ++-
 elbepack/commands/show.py               |  3 +-
 elbepack/commands/toolchainextract.py   |  2 +-
 elbepack/commands/updated.py            |  2 +-
 elbepack/commands/validate.py           |  2 +-
 elbepack/commands/xsdtoasciidoc.py      |  3 +-
 elbepack/config.py                      |  1 +
 elbepack/daemons/soap/__init__.py       |  5 ---
 elbepack/daemons/soap/authentication.py |  3 +-
 elbepack/daemons/soap/esoap.py          | 15 +++++++-
 elbepack/daemons/soap/faults.py         |  4 +-
 elbepack/db.py                          | 20 ++++++++--
 elbepack/dbaction.py                    |  9 +++--
 elbepack/debianize/barebox.py           |  4 +-
 elbepack/debianize/base.py              | 13 ++++++-
 elbepack/debianize/kernel.py            |  6 ++-
 elbepack/debpkg.py                      |  3 ++
 elbepack/directories.py                 |  4 +-
 elbepack/dump.py                        | 20 +++++++---
 elbepack/efilesystem.py                 |  5 ++-
 elbepack/elbeproject.py                 | 22 +++++++++--
 elbepack/elbexml.py                     | 19 ++++++----
 elbepack/finetuning.py                  | 52 ++++++++++++++-----------
 elbepack/fstab.py                       | 19 ++++++++++
 elbepack/gpg.py                         |  5 ++-
 elbepack/hdimg.py                       | 25 +++++++-----
 elbepack/initvmaction.py                | 67 ++++++++++++++++++++-------------
 elbepack/licencexml.py                  |  9 +++--
 elbepack/pbuilder.py                    |  2 +-
 elbepack/pbuilderaction.py              | 27 +++++++------
 elbepack/pkgarchive.py                  | 12 ++++--
 elbepack/pkgutils.py                    | 19 +++++++++-
 elbepack/repomanager.py                 | 11 ++++++
 elbepack/rfs.py                         |  5 ++-
 elbepack/rpcaptcache.py                 | 26 +++++++++----
 elbepack/shellhelper.py                 | 22 +++++------
 elbepack/soapclient.py                  | 59 +++++++++++++++++------------
 elbepack/toolchain.py                   |  6 ++-
 elbepack/treeutils.py                   |  4 +-
 elbepack/updated.py                     | 36 +++++++++++++-----
 elbepack/updatepkg.py                   |  6 ++-
 elbepack/version.py                     |  3 +-
 elbepack/virtapt.py                     | 19 +++++++---
 elbepack/xmldefaults.py                 |  2 +-
 elbepack/xmlpreprocess.py               |  2 +
 elbepack/ziparchives.py                 |  2 +-
 68 files changed, 514 insertions(+), 253 deletions(-)

-- 
2.11.0