[elbe-devel] [PATCH 00/28] second part of the pylint patchqeue

Torben Hohn torben.hohn at linutronix.de
Wed Aug 22 11:28:54 CEST 2018


again fixes quite a lot of pylint complaints.

pylint commandline used:

------------------------------------------------------------------------------
pylint -f parseable \
       --extension-pkg-whitelist=apt_pkg,gpgme,lxml.etree,_ped \
       --generated-members=gpgme.SIGSUM_*,gpgme.SIG_MODE_NORMAL \
       "$@"
------------------------------------------------------------------------------

+-----------+-------+---------+-----------+                                  
|type       |number |previous |difference |                                  
+===========+=======+=========+===========+                                  
|convention |10     |40       |-30.00     |                                  
+-----------+-------+---------+-----------+                                  
|refactor   |96     |129      |-33.00     |                                  
+-----------+-------+---------+-----------+                                  
|warning    |112    |169      |-57.00     |                                  
+-----------+-------+---------+-----------+                                  
|error      |14     |23       |-9.00      |                                  
+-----------+-------+---------+-----------+                                  


Torben Hohn (28):
  pylint: fix unnecessary parenthesis warnings
  pylint efilesystem: add missing () to close
  pylint: rename variables, that shadow built-in or outer scope names
  pylint: disable more too-many-* messages
  pylint: efilesystem: use proper name for destructor.
  pylint: mark unused arguments
  pylint: fix indent complaints
  pylint: pbuilderaction: fix multiple statements per line warning
  pylint: fix unidiomatic typechecks
  pylint: fstab: call baseclass.__init__() in constructor
  pylint: repomanager: group imports
  pylint: soapclient: remove unused pass
  pylint pkgutils: disable pylint complaint about import grouping
  pylint: fix unnecessary parenthesis
  pylint: disable too-many-*
  pylint: fix wrong indent levels
  pylint: fix unnecessary pass statements
  pylint: remove unused import statements
  pylint: bootup-check: mark argv argument as unused
  pylint: parselicence: call baseclass dict.__init__() in constructor
  pylint: daemons soap: fix self parameters called ctx
  pylint: daemons soap faults: fix Exception order in soap_faults()
  pylint: daemons soap: improve import grouping
  pylint: debianize: only set attributes in constructor
  pylint: debianize: stop pylint from complaining about unused imports
  pylint: rename variables that redefine built-in, or outer scope names
  pylint: db: convert "if x: return True else: False" to "return x"
  pylint: virtapt: make pylint not complain about unused import apt.

 elbepack/aptpkgutils.py            |  2 +-
 elbepack/aptprogress.py            |  2 +-
 elbepack/commands/adjustpkgs.py    |  2 +-
 elbepack/commands/bootup-check.py  |  2 +-
 elbepack/commands/check_updates.py |  1 +
 elbepack/commands/chg_archive.py   |  1 -
 elbepack/commands/control.py       |  4 ++--
 elbepack/commands/diff.py          |  3 +++
 elbepack/commands/gen_update.py    |  1 +
 elbepack/commands/init.py          |  1 +
 elbepack/commands/parselicence.py  |  4 +++-
 elbepack/commands/pkgdiff.py       |  5 +++--
 elbepack/commands/prjrepo.py       |  4 ++--
 elbepack/commands/remove_sign.py   |  2 +-
 elbepack/commands/show.py          |  3 +++
 elbepack/commands/sign.py          |  2 +-
 elbepack/daemons/soap/__init__.py  |  2 +-
 elbepack/daemons/soap/esoap.py     | 16 +++++++++-------
 elbepack/daemons/soap/faults.py    | 28 ++++++++++++++--------------
 elbepack/db.py                     | 21 ++++++++++-----------
 elbepack/debianize/barebox.py      |  7 +++++++
 elbepack/debianize/base.py         |  1 +
 elbepack/debianize/debianize.py    |  3 +++
 elbepack/debianize/kernel.py       |  7 +++++++
 elbepack/dump.py                   | 22 ++++++++++++----------
 elbepack/efilesystem.py            | 21 +++++++++++----------
 elbepack/elbeproject.py            |  2 ++
 elbepack/elbexml.py                | 14 ++++++++------
 elbepack/filesystem.py             |  3 +++
 elbepack/fstab.py                  |  1 +
 elbepack/gpg.py                    |  3 ---
 elbepack/hdimg.py                  | 21 +++++++++++++--------
 elbepack/initvmaction.py           |  2 +-
 elbepack/licencexml.py             |  8 ++++----
 elbepack/pbuilder.py               |  2 +-
 elbepack/pbuilderaction.py         | 10 ++++++----
 elbepack/pkgarchive.py             |  4 ++--
 elbepack/pkgutils.py               |  5 +++++
 elbepack/projectmanager.py         |  3 +++
 elbepack/repomanager.py            |  7 ++++---
 elbepack/rfs.py                    |  5 +++--
 elbepack/rpcaptcache.py            | 13 +++++++------
 elbepack/soapclient.py             |  9 ++++-----
 elbepack/treeutils.py              |  4 ++--
 elbepack/updated.py                |  8 ++++----
 elbepack/updatepkg.py              |  1 +
 elbepack/virtapt.py                | 15 +++++++--------
 elbepack/xmlpreprocess.py          |  1 +
 48 files changed, 182 insertions(+), 126 deletions(-)

-- 
2.11.0




More information about the elbe-devel mailing list