[elbe-devel] [PATCH] preprocess: always set --variant=default

John Ogness john.ogness at linutronix.de
Thu Dec 6 10:25:13 CET 2018


On 2018-12-05, Manuel Traut <manut at linutronix.de> wrote:
>> With this change elbe uses --variant=default as default. So
>> 
>> <hostname variant="default">test</hostname>
>> <hostname variant="ng">test-ng</hostname>
>> 
>> will work for both calls described above.
>
> while trying to cleanup the example directory using variants
> (with this patch) i found a big limitation:
>
> <buildtype variant="default">amd64</buildtype>
> <buildtype variant="arm">armhf</buildtype>
> ..
> <hostname variant="default">desktop</hostname>
> <hostname variant="specialname">specialname</hostname>
> ..
> If i now specify --variant=arm i get an invalid XML because
> hostname is not set. If a third OR element will be used it
> becomes even worse..

Wouldn't it be easier to implement:

<hostname variant="">default when no --variant</hostname>
<hostname variant="*">fallback when unknown --variant</hostname>

John Ogness



More information about the elbe-devel mailing list