[elbe-devel] [PATCH v2 01/24] soap/wait_busy: don't drop exception silently

[Torben Hohn]

On Thu, Feb 08, 2018 at 02:16:47PM +0100, Manuel Traut wrote:
> printout if dropping a log part. Instead of hiding the issue. I've seen
> some strange behaviour once, but wasn't able to reproduce it. Hopefully
> this improves debugablility.
> 
> Also cleanup the unreadable line-breaks in the print introduced by autopep8.
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/soapclient.py | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/elbepack/soapclient.py b/elbepack/soapclient.py
> index 213840b3..3877cb0f 100644
> --- a/elbepack/soapclient.py
> +++ b/elbepack/soapclient.py
> @@ -512,13 +512,10 @@ class WaitProjectBusyAction(ClientAction):
>  
>                          localtime = time.asctime(time.localtime(time.time()))
>                          try:
> -                            print(
> -                                localtime +
> -                                " -- " +
> -                                log[1].replace(
> -                                    '\n',
> -                                    ''))
> +                            print("%s -- %s" % (localtime,
> +                                                log[1].replace('\n','')))
>                          except IndexError:
> +                            print("IndexError - part: %d (skipped)" % part)
>                              pass
>                      else:
>                          time.sleep(1)
> -- 
> 2.15.1
> 

-- 
Mit freundlichen Grüßen
Torben Hohn

Linutronix GmbH

Standort: Bremen

Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
Nr. / Trade register no.: 700 806

Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner

Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
möglich ist, durch Antwort-Mail. Vielen Dank!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180208/d0525c57/attachment.sig>