[elbe-devel] [PATCH 2/7] pep8: fix E211 whitespace before '('

Torben Hohn torben.hohn at linutronix.de
Fri Jan 5 11:23:24 CET 2018


On Wed, Dec 20, 2017 at 10:11:42PM +0100, Manuel Traut wrote:
> this updates pycodestyle statistics to:
> 
> 6       E265 block comment should start with '# '
> 3       E266 too many leading '#' for block comment
> 2       E402 module level import not at top of file
> 98      E501 line too long (82 > 79 characters)
> 7       E741 ambiguous variable name 'l'
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/commands/validate.py |  2 +-
>  elbepack/initvmaction.py      | 14 +++++++-------
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/elbepack/commands/validate.py b/elbepack/commands/validate.py
> index dea91378..589ed2d7 100644
> --- a/elbepack/commands/validate.py
> +++ b/elbepack/commands/validate.py
> @@ -25,7 +25,7 @@ def run_command(argv):
>          sys.exit(20)
>  
>      if not os.path.exists(args[0]):
> -        print ("%s - file not found" % args[0])
> +        print("%s - file not found" % args[0])
>          oparser.print_help()
>          sys.exit(20)
>  
> diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
> index 0015db92..92899930 100644
> --- a/elbepack/initvmaction.py
> +++ b/elbepack/initvmaction.py
> @@ -240,7 +240,7 @@ class CreateAction(InitVMAction):
>                  tmp = TmpdirFilesystem()
>                  os.system('7z x -o%s "%s" source.xml' % (tmp.path, args[0]))
>  
> -                print ('', file=sys.stderr)
> +                print('', file=sys.stderr)
>  
>                  if not tmp.isfile('source.xml'):
>                      print(
> @@ -425,7 +425,7 @@ class CreateAction(InitVMAction):
>                  print("Giving up", file=sys.stderr)
>                  sys.exit(20)
>  
> -            print ("Build started, waiting till it finishes")
> +            print("Build started, waiting till it finishes")
>  
>              try:
>                  system('%s control wait_busy "%s"' % (elbe_exe, prjdir))
> @@ -472,9 +472,9 @@ class CreateAction(InitVMAction):
>                      'Get Files with: elbe control get_file "%s" <filename>' %
>                      prjdir)
>              else:
> -                print ("")
> -                print ("Getting generated Files")
> -                print ("")
> +                print("")
> +                print("Getting generated Files")
> +                print("")
>  
>                  ensure_outdir(wdfs, opt)
>  
> @@ -491,8 +491,8 @@ class CreateAction(InitVMAction):
>                          system('%s control del_project "%s"' % (
>                              elbe_exe, prjdir))
>                      except CommandError:
> -                        print ("remove project from initvm failed",
> -                               file=sys.stderr)
> +                        print("remove project from initvm failed",
> +                              file=sys.stderr)
>                          sys.exit(20)
>  
>  
> -- 
> 2.15.1
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Mit freundlichen Grüßen
Torben Hohn

Linutronix GmbH

Standort: Bremen

Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
Nr. / Trade register no.: 700 806

Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner

Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
möglich ist, durch Antwort-Mail. Vielen Dank!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180105/8be93c87/attachment.sig>


More information about the elbe-devel mailing list