[elbe-devel] [PATCH 7/7] pep8: fix E501 line too long (X > 79 characters)

Torben Hohn torben.hohn at linutronix.de
Fri Jan 5 12:10:14 CET 2018


On Wed, Dec 20, 2017 at 10:11:47PM +0100, Manuel Traut wrote:
> to match the 79 char limit the following changes were made in different
> files:
> 
>  * strings in brackets are seperated with their limiters and splitted into
>    multiple lines
> 
>  * if statements are splitted into multiple lines using '\'

not a fan of these... adding an additional '(' also allows linebreaks in 
if statements...

>>> if ((1==2) 
... or 2==3
... or 3):

anyways... lets have what we have now.

> 
>  * super long function calls with a lot of parameters are splitted into
>    multiple lines
> 
>  * additional brackets are added to allow additional line breaks
> 
>  * long lines accessing arrays are put into multiple lines after '['
> 
>  * use shorter variable names if this makes it possible to put a statement
>    into a single line
> 
>  * rework comments to fit into the 79 char limit
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/asciidoclog.py           |  8 ++--
>  elbepack/commands/adjustpkgs.py   |  9 +++--
>  elbepack/commands/buildchroot.py  |  4 +-
>  elbepack/commands/chg_archive.py  |  6 ++-
>  elbepack/commands/control.py      | 11 ++++--
>  elbepack/commands/diff.py         | 15 ++++----
>  elbepack/commands/init.py         |  7 ++--
>  elbepack/commands/initvm.py       |  3 +-
>  elbepack/commands/parselicence.py |  6 ++-
>  elbepack/commands/pkgdiff.py      | 12 ++++--
>  elbepack/commands/prjrepo.py      |  9 +++--
>  elbepack/commands/sign.py         |  3 +-
>  elbepack/daemons/soap/esoap.py    | 10 ++---
>  elbepack/daemons/soap/faults.py   |  3 +-
>  elbepack/db.py                    | 12 ++++--
>  elbepack/debianize/barebox.py     |  3 +-
>  elbepack/debianize/base.py        |  4 +-
>  elbepack/debianize/kernel.py      |  7 ++--
>  elbepack/efilesystem.py           | 12 +++---
>  elbepack/elbeproject.py           | 78 ++++++++++++++++++++-------------------
>  elbepack/elbexml.py               | 15 ++++----
>  elbepack/fstab.py                 |  8 ++--
>  elbepack/gpg.py                   |  5 ++-
>  elbepack/hdimg.py                 | 11 +++---
>  elbepack/initvmaction.py          | 31 +++++++++-------
>  elbepack/pbuilder.py              | 27 ++++++--------
>  elbepack/pkgarchive.py            |  4 +-
>  elbepack/pkgutils.py              |  9 +++--
>  elbepack/projectmanager.py        | 24 ++++++------
>  elbepack/repomanager.py           | 24 +++++-------
>  elbepack/rfs.py                   | 58 ++++++++++++++++-------------
>  elbepack/rpcaptcache.py           | 25 ++++++++-----
>  elbepack/soapclient.py            | 10 ++---
>  elbepack/toolchain.py             |  4 +-
>  elbepack/validate.py              |  4 +-
>  elbepack/virtapt.py               | 14 ++++---
>  setup.py                          | 21 +++++++----
>  37 files changed, 284 insertions(+), 232 deletions(-)

-- 
Mit freundlichen Grüßen
Torben Hohn

Linutronix GmbH

Standort: Bremen

Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
Nr. / Trade register no.: 700 806

Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner

Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
möglich ist, durch Antwort-Mail. Vielen Dank!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: Digital signature
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180105/f4b40e1a/attachment.sig>


More information about the elbe-devel mailing list