[elbe-devel] [PATCH] archivedir: Fail elbe chg_archive on tar errors

[Benedikt Spranger]

Error from tar are reported to stderr/stdout but not recognized in
elbe chg_archive:

$ elbe chg_archive preprocess.xml overlay/
tar: ./unaccessable: Cannot open: Permission denied
tar: Exiting with failure status due to previous errors
Error reading archive
$ echo $?
0

Convert os.system call to subprocess.check_call to recognize the failure
and set a proper exit code:

$ elbe chg_archive preprocess.xml overlay/
tar: ./unaccessable: Cannot open: Permission denied
tar: Exiting with failure status due to previous errors
Error reading archive
$ echo $?
20

Signed-off-by: Benedikt Spranger <b.spranger at linutronix.de>
Reviewed-by: Manuel Traut <manut at linutronix.de>
---
 elbepack/archivedir.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/elbepack/archivedir.py b/elbepack/archivedir.py
index 96b0ccb4..9b3b307a 100644
--- a/elbepack/archivedir.py
+++ b/elbepack/archivedir.py
@@ -6,6 +6,8 @@
 import os
 
 from base64 import standard_b64encode
+from subprocess import check_call
+
 from elbepack.treeutils import etree
 
 def enbase(fname):
@@ -30,7 +32,7 @@ def chg_archive(xml, path, keep):
         else:
             cmd = 'tar cjf .archive.tbz --owner=root --group=root -C '
         cmd += path + ' .'
-        os.system(cmd)
+        check_call(cmd, shell=True)
     else:
         archive = path
 
-- 
2.18.0