[elbe-devel] [PATCH] elbeproject: set grub_fw_type when building wheezy project

[Manuel Traut]

Hi Martin,

On Fri, May 04, 2018 at 08:12:53AM +0200, Martin Kaistra wrote:
> The variable grub_fw_type didn't get set if the elbe project
> was of type wheezy which resulted in a build failure
> (github issue #156). Set grub_fw_type also in this missing case.
> 
> Command failed with errorcode 1
> Build failed
> Traceback (most recent call last):
> File "/usr/lib/python2.7/dist-packages/elbepack/asyncworker.py", line 129, in execute
> skip_pbuild=self.skip_pbuilder)
> File "/usr/lib/python2.7/dist-packages/elbepack/elbeproject.py", line 489, in build
> self.targetfs.part_target(self.builddir, grub_version, grub_fw_type)
> UnboundLocalError: local variable 'grub_fw_type' referenced before assignment
> 
> Exception:
> local variable 'grub_fw_type' referenced before assignment
> 
> Signed-off-by: Martin Kaistra <martin.kaistra at linutronix.de>
Reviewed-by: Manuel Traut <manut at linutronix.de>

Thanks a lot! It's merged into devel/elbe-3.0

> ---
>  elbepack/elbeproject.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
> index 690a289d..f2c8fa9f 100644
> --- a/elbepack/elbeproject.py
> +++ b/elbepack/elbeproject.py
> @@ -472,7 +472,7 @@ class ElbeProject (object):
>                  grub_version = 199
>              else:
>                  grub_version = 202
> -                grub_fw_type = "bios"
> +            grub_fw_type = "bios"
>          elif self.get_rpcaptcache().is_installed('grub-efi-amd64'):
>              grub_version = 202
>              grub_fw_type = "efi"
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel