[elbe-devel] [PATCH 4/6] xmldefaults: add defaults for mem and swap-size

[Torben Hohn]

On Mon, May 07, 2018 at 04:33:30PM +0200, Manuel Traut wrote:
> On Mon, May 07, 2018 at 03:51:13PM +0200, Torben Hohn wrote:
> > when adding mem and swap-size, we need proper defaults, for xml
> > files not specifying these.
> > 
> > mem and swap-size will be evaluated in libvirt.xml.mako in a later patch
> > 
> > Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
> > ---
> >  elbepack/xmldefaults.py | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/elbepack/xmldefaults.py b/elbepack/xmldefaults.py
> > index ebaafcaf..02eecb11 100644
> > --- a/elbepack/xmldefaults.py
> > +++ b/elbepack/xmldefaults.py
> > @@ -154,6 +154,8 @@ archindep_defaults = {
> >      "name": "elbe-buildenv",
> >      "size": "20G",
> >      "img": "qcow2",
> > +    "mem": "1048576",
> > +    "swap-size": "0"
> >  }
> 
> needs rework, see comment in 3/6

xmldefault should really be strings. 
they are returned from xml.text().
i dont think it should return string, when its specified in xml
and int, when the default is returned.

0 is also a valid part_size. 

this comes down to deciding, how we want to specify mem.


-- 
Mit freundlichen Grüßen
Torben Hohn

Linutronix GmbH

Standort: Bremen

Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Firmensitz / Registered Office: D-88690 Uhldingen, Bahnhofstr. 3
Registergericht / Local District Court: Amtsgericht Freiburg i. Br.; HRB
Nr. / Trade register no.: 700 806

Geschäftsführer / Managing Directors: Heinz Egger, Thomas Gleixner

Eine Bitte von uns: Sollten Sie diese E-Mail irrtümlich erhalten haben,
benachrichtigen Sie uns in diesem Falle bitte sobald wie es Ihnen
möglich ist, durch Antwort-Mail. Vielen Dank!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180508/094f728a/attachment.sig>