[elbe-devel] [PATCH 0/9] project finetuning

Manuel Traut manut at linutronix.de
Fri Nov 30 15:32:11 CET 2018


Hi Torben,

with the current cover-letter the patchset is hard to understand.
(As you can see on the review comments of the first patches were
 i was confused that the feature is called project_finetuning)
However, i like the term project finetuning now as i understood
that there is also image finetuning introduced later.

So please improve the cover letter and describe the architecture
of the improved finetuning.

Also clearly mention what is implemented in the patchset. And what
is posible with the new infrastructure, but currently not implemented:
* sign images
* crypt setup
* UEFI / secureboot
that we can open new issues for that.

I'm looking forward to see a v2 of the queue. Because basicly i really
like it! Just fixup the few technical bits and improve documentation
and than it's ready for integration :)

Thanks a lot!

  Manu

On 17:28 Wed 28 Nov     , Torben Hohn wrote:
> Implement <project-finetuning> which is executed after image generation.
> 
> The primary goal is to support the extraction of partition images.
> But project finetuning makes more things possible:
> 
> * sign images
> * crypt setup
> * extract partition from image and mark as build artifact.
> * modify images (iE remove some modules from /boot/grub)
> * UEFI / secureboot: make_lxtrainer_secureboot.sh
> * mark files as build artifacts
> 
> style fixes and a fix for building, when the initvm was generated
> by an older version of elbe have also been included into this queue.
> 
> 
> Torben Hohn (9):
>   finetuning: basic implementation of project-finetuning
>   finetuning: imeplement projcmd for project-finetuning
>   finetuning: add artifact and rm_artifact command to project-finetuning
>   hdimg efilesystem: compress images later in the process
>   pylint elbeproject: fix styleproblems
>   finetuning: implement <mount_drive> action
>   finetuning: implement ImageFinetuningAction <extract_partition>
>   cdroms: do not fail without /var/cache/elbe/initvm-bin-repo
>   examples: add a <project-finetuning> section
> 
>  elbepack/cdroms.py                             |  12 ++-
>  elbepack/efilesystem.py                        |  14 +++
>  elbepack/elbeproject.py                        |  57 +++++-----
>  elbepack/finetuning.py                         | 142 +++++++++++++++++++++++++
>  elbepack/hdimg.py                              |  13 +--
>  examples/x86_64-pc-hdimg-grub-uefi-stretch.xml |   6 ++
>  schema/dbsfed.xsd                              | 124 +++++++++++++++++++++
>  7 files changed, 332 insertions(+), 36 deletions(-)
> 
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel



More information about the elbe-devel mailing list