[elbe-devel] [PATCH v3 5/8] pylint cdroms: cleanup

Manuel Traut manut at linutronix.de
Fri Oct 19 11:47:46 CEST 2018


On Mon, Oct 15, 2018 at 03:18:03PM +0200, Torben Hohn wrote:
> pylint complains:
> 
> elbepack/cdroms.py:43:8: E714 test for object identity should be 'is not'
> elbepack/cdroms.py:44:40: E211 whitespace before '('
> elbepack/cdroms.py:46:15: E225 missing whitespace around operator
> 
> fix em

Reviewed-by: Manuel Traut <manut at linutronix.de>

> ---
>  elbepack/cdroms.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/elbepack/cdroms.py b/elbepack/cdroms.py
> index d7207e44..9684e12f 100644
> --- a/elbepack/cdroms.py
> +++ b/elbepack/cdroms.py
> @@ -40,10 +40,10 @@ def mk_source_cdrom(
>      hostfs.mkdir_p('/var/cache/elbe/sources')
>      rfs.mkdir_p('/var/cache/elbe/sources')
>  
> -    if not xml is None:
> -        mirror = xml.get_primary_mirror (rfs.fname("cdrom"))
> +    if xml is not None:
> +        mirror = xml.get_primary_mirror(rfs.fname("cdrom"))
>      else:
> -        mirror='http://ftp.de.debian.org/debian'
> +        mirror = 'http://ftp.de.debian.org/debian'
>  
>      repo = CdromSrcRepo(codename, init_codename,
>                          os.path.join(target, "srcrepo"),
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel



More information about the elbe-devel mailing list