[elbe-devel] [PATCH v2 0/7] elbe pbuilder preprocess

Manuel Traut manut at linutronix.de
Fri Oct 19 13:59:09 CEST 2018


Hi Torben,

all reviewed and merged.

Thanks!

On Mon, Oct 15, 2018 at 12:43:13PM +0200, Torben Hohn wrote:
> Patchqueue to implement preprocess support into "elbe pbuilder"
> 
> In order to not add duplicated code, this queue starts by
> abstracting the call to elbe preprocess into a separate Object.
> Then elbepack.initvmaction is switched to using the new object.
> 
> Review comments for V1 patch mentioned, that --variant is not
> supported. So the PreprocessWrapper object is extended to
> a) allow adding preprocess options that shall be passed through
> b) pass through options from the parents opt object.
> 
> a patch to .pylintrc slipped in. 
> 
> And finally the actual support for calling preprocess from
> "elbe pbuilder create" is added.
> 
> 
> The handling of the options should serve as a template for
> passing more options to other commands later.
> "elbe initvm" calls "elbe control" and "elbe init"
> 
> ChangeLog for V2:
> 
> * this is all completely new.
> 
> 
> Switching to feature branches now.
> This is 3f6be9601bbe ("pbuilder: add support for preprocess by using the new PreprocessWrapper")
> from devel/torbenh/pbuilder_preprocess
> 
> 
> Torben Hohn (7):
>   xmlpreprocess: apply autopep8
>   xmlpreprocess: add PreprocessWrapper to consolidate calling 'elbe
>     preprocess'
>   initvmaction: call 'elbe preprocess' through PreprocessWrapper
>   commands preprocess: isolate "pass_through" options
>   xmlpreprocess initvm: add support for passing options to "elbe
>     preprocess"
>   .pylintrc: remove required-attributed and ignore-iface-methods
>   pbuilder: add support for preprocess by using the new
>     PreprocessWrapper
> 
>  .pylintrc                       |  7 -----
>  elbepack/commands/initvm.py     |  3 ++
>  elbepack/commands/pbuilder.py   |  6 +++-
>  elbepack/commands/preprocess.py | 10 +++++--
>  elbepack/initvmaction.py        | 50 ++++++++++++++++-----------------
>  elbepack/pbuilderaction.py      | 42 +++++++++++++++++-----------
>  elbepack/xmlpreprocess.py       | 61 ++++++++++++++++++++++++++++++++++++++---
>  7 files changed, 122 insertions(+), 57 deletions(-)
> 
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel



More information about the elbe-devel mailing list