[elbe-devel] [PATCH] debianize: call DebianizeBase.__init__() after setting attributes to None

[Manuel Traut]

Hi Torben, Kurt,

On Mon, Oct 08, 2018 at 05:14:56PM +0200, Kurt Kanzenbach wrote:
> Hi Torben,
> 
> On Mon, Oct 08, 2018 at 05:09:16PM +0200, Torben Hohn wrote:
> > gui() seems to be called from FormMultiPage.__init__() via
> > DebianizeBase.create() after that, the self.loadaddr and friends are
[..]
> > move the call to DebianizeBase.__init__() below attribute initialisation.
> >
> > Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>
> 
> Tested-by: Kurt Kanzenbach <kurt at linutronix.de>
> 
> it solves the issue for me.

thanks for developing and testing!

merged into devel/elbe-3.0

> > ---
> >  elbepack/debianize/barebox.py | 4 ++--
> >  elbepack/debianize/kernel.py  | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/elbepack/debianize/barebox.py b/elbepack/debianize/barebox.py
> > index ff9d70dc..90cb51df 100644
> > --- a/elbepack/debianize/barebox.py
> > +++ b/elbepack/debianize/barebox.py
> > @@ -22,13 +22,13 @@ class BareBox (DebianizeBase):
> >      files = ['Kbuild', 'Kconfig', 'README', 'TODO']
> >
> >      def __init__(self):
> > -        DebianizeBase.__init__(self)
> > -
> >          self.defconfig = None
> >          self.imgname = None
> >          self.cross = None
> >          self.k_version = None
> >
> > +        DebianizeBase.__init__(self)
> > +
> >      def gui(self):
> >          self.defconfig = self.add_widget_intelligent(
> >              TitleText, name="defconfig:", value="imx_v7_defconfig")
> > diff --git a/elbepack/debianize/kernel.py b/elbepack/debianize/kernel.py
> > index 3aeda851..227985a3 100644
> > --- a/elbepack/debianize/kernel.py
> > +++ b/elbepack/debianize/kernel.py
> > @@ -26,13 +26,13 @@ class Kernel (DebianizeBase):
> >      def __init__(self):
> >          self.imgtypes = ["bzImage", "zImage", "uImage", "Image"]
> >          self.imgtypes_install = ["install", "zinstall", "uinstall", "install"]
> > -        DebianizeBase.__init__(self)
> >
> >          self.loadaddr = None
> >          self.defconfig = None
> >          self.imgtype = None
> >          self.cross = None
> >          self.k_version = None
> > +        DebianizeBase.__init__(self)
> >
> >      def gui(self):
> >          self.loadaddr = self.add_widget_intelligent(
> > --
> > 2.11.0
> >
> >
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel