[elbe-devel] [PATCH 1/3] initvmaction: remove start_build, because we dont want to depend on tmux anymore

[Manuel Traut]

On Fri, Sep 28, 2018 at 10:39:52AM +0200, Torben Hohn wrote:
> start_build depends on tmux. since we are using libvirt now, we want
> to drop the tmux dependency.
>

it should be safe to
> remove "elbe initvm start_build".
because it is hopefully unused.

At least noone on the elbe-devel ML complained.

> Signed-off-by: Torben Hohn <torben.hohn at linutronix.de>

Reviewed-by: Manuel Traut <manut at linutronix.de>

> ---
>  docs/elbe-initvm.txt     |  7 -------
>  elbepack/initvmaction.py | 27 ---------------------------
>  2 files changed, 34 deletions(-)
> 
> diff --git a/docs/elbe-initvm.txt b/docs/elbe-initvm.txt
> index b53518b6..64603d22 100644
> --- a/docs/elbe-initvm.txt
> +++ b/docs/elbe-initvm.txt
> @@ -16,7 +16,6 @@ SYNOPSIS
>  'elbe initvm' [options] 'start'
>  'elbe initvm' [options] 'stop'
>  'elbe initvm' [options] 'ensure'
> -'elbe initvm' [options] 'start_build'
>  
>  DESCRIPTION
>  -----------
> @@ -114,12 +113,6 @@ Shutdown running initvm.
>  Make sure an initvm is running in the Background.
>  
>  
> -'start_build'::
> -
> -Runs an initvm build in the Background. The build directory must have been
> -created with `elbe init` beforehand.
> -
> -
>  Examples
>  --------
>  
> diff --git a/elbepack/initvmaction.py b/elbepack/initvmaction.py
> index 5597de13..fdcdd571 100644
> --- a/elbepack/initvmaction.py
> +++ b/elbepack/initvmaction.py
> @@ -214,33 +214,6 @@ class AttachAction(InitVMAction):
>  InitVMAction.register(AttachAction)
>  
>  
> -class StartBuildAction(InitVMAction):
> -
> -    tag = 'start_build'
> -
> -    def __init__(self, node):
> -        InitVMAction.__init__(self, node)
> -
> -    def execute(self, initvmdir, _opt, _args):
> -        try:
> -            have_session = os.system(
> -                "tmux has-session -t ElbeInitVMSession >/dev/null 2>&1")
> -        except CommandError:
> -            print("tmux exec failed, tmux version 1.9 or higher is required")
> -            sys.exit(20)
> -        if have_session != 256:
> -            print("ElbeInitVMSession already exists in tmux.", file=sys.stderr)
> -            print(
> -                "Try 'elbe initvm attach' to attach to the session.",
> -                file=sys.stderr)
> -            sys.exit(20)
> -
> -        system('TMUX= tmux new-session -d -s ElbeInitVMSession -n initvm '
> -               '"cd \"%s\"; make"' % initvmdir)
> -
> -
> -InitVMAction.register(StartBuildAction)
> -
>  def submit_and_dl_result(xmlfile, cdrom, opt):
>  
>      # pylint: disable=too-many-statements
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel