[elbe-devel] [PATCH 1/4] db: fix useless statement 'None'

[Torben Hohn]

On Fri, Sep 14, 2018 at 01:53:02PM +0200, Manuel Traut wrote:
> pylint informs about that 'None' is a useless statement. The code
> introduced in
> 
> --8<--
> commit 94f632f5a2109d64e0b819c8f1757a34d2ccda68
> Author: Manuel Traut <manut at linutronix.de>
> Date:   Tue Dec 16 15:51:13 2014 +0100
> 
>     postbuild: add a hook for a postbuild script
> --8<--
> 
> should return None if the file that should be added to the DB doesn't
> exist.
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/db.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/elbepack/db.py b/elbepack/db.py
> index fe14195e..334207ad 100644
> --- a/elbepack/db.py
> +++ b/elbepack/db.py
> @@ -885,7 +885,7 @@ class ElbeDB(object):
>              f.description = description
>          else:
>              s.delete(f)
> -            None
> +            return None
>  
>          return filename
>  
> -- 
> 2.19.0.rc2
> 

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180920/2574779a/attachment.sig>