[elbe-devel] [PATCH 18/40] pylint: elbeproject: unused parameter skip_debootstrap

[Torben Hohn]

On Fri, Sep 14, 2018 at 01:56:30PM +0200, Manuel Traut wrote:
> remove parameter and fixup all callers
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/commands/buildchroot.py | 5 -----
>  elbepack/dbaction.py             | 2 +-
>  elbepack/elbeproject.py          | 5 ++---
>  3 files changed, 3 insertions(+), 9 deletions(-)
> 
> diff --git a/elbepack/commands/buildchroot.py b/elbepack/commands/buildchroot.py
> index ca243c1d..6c0f14f6 100644
> --- a/elbepack/commands/buildchroot.py
> +++ b/elbepack/commands/buildchroot.py
> @@ -68,10 +68,6 @@ def run_command(argv):
>                         dest="skip_validation", default=False,
>                         help="Skip xml schema validation")
>  
> -    oparser.add_option("--skip-debootstrap", action="store_true",
> -                       dest="skip_debootstrap", default=False,
> -                       help="Skip debootstrap")
> -
>      oparser.add_option("--skip-pkglist", action="store_true",
>                         dest="skip_pkglist", default=False,
>                         help="ignore changes of the package list")
> @@ -105,7 +101,6 @@ def run_command(argv):
>  
>      try:
>          project.build(
> -            opt.skip_debootstrap,
>              opt.build_bin,
>              opt.build_sources,
>              opt.cdrom_size,
> diff --git a/elbepack/dbaction.py b/elbepack/dbaction.py
> index a67d2d9c..7cd66314 100644
> --- a/elbepack/dbaction.py
> +++ b/elbepack/dbaction.py
> @@ -267,7 +267,7 @@ class BuildAction(DbAction):
>                                "build_done", "build_failed"])
>          try:
>              ep = db.load_project(args[0])
> -            ep.build(skip_debootstrap=True)
> +            ep.build()
>              db.update_project_files(ep)
>          except Exception as e:
>              db.update_project_files(ep)
> diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
> index 1e2b0287..d19673ce 100644
> --- a/elbepack/elbeproject.py
> +++ b/elbepack/elbeproject.py
> @@ -409,9 +409,8 @@ class ElbeProject (object):
>                      # e.g. no deb-src urls specified
>                      elog.printo(str(e))
>  
> -    def build(self, skip_debootstrap=False, build_bin=False,
> -              build_sources=False, cdrom_size=None, debug=False,
> -              skip_pkglist=False, skip_pbuild=False):
> +    def build(self, build_bin=False, build_sources=False, cdrom_size=None,
> +              debug=False, skip_pkglist=False, skip_pbuild=False):
>  
>          # pylint: disable=too-many-arguments
>          # pylint: disable=too-many-locals
> -- 
> 2.19.0.rc2
> 

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180920/b43e30c7/attachment.sig>