[elbe-devel] [PATCH 19/40] pylint: rmlog - remove unused parameter

Torben Hohn torben.hohn at linutronix.de
Thu Sep 20 12:09:41 CEST 2018


once we allow that one user has more than one project open, we need the
parameter again.

hmm... but we need it everywhere then.
maybe its ok, if we remove it, until we are ready to fix this whole
projectmanager._get_current_project(userid) crap.

On Fri, Sep 14, 2018 at 01:56:31PM +0200, Manuel Traut wrote:
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/daemons/soap/esoap.py | 2 +-
>  elbepack/projectmanager.py     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/daemons/soap/esoap.py b/elbepack/daemons/soap/esoap.py
> index dfed16e0..63dbc826 100644
> --- a/elbepack/daemons/soap/esoap.py
> +++ b/elbepack/daemons/soap/esoap.py
> @@ -353,7 +353,7 @@ class ESoap (ServiceBase):
>      @soap_faults
>      def rm_log(self, uid, builddir):
>          self.app.pm.open_project(uid, builddir)
> -        self.app.pm.rm_log(uid, builddir)
> +        self.app.pm.rm_log(uid)


>  
>      @rpc(String, _returns=String)
>      @authenticated_uid
> diff --git a/elbepack/projectmanager.py b/elbepack/projectmanager.py
> index b2593630..e8613bca 100644
> --- a/elbepack/projectmanager.py
> +++ b/elbepack/projectmanager.py
> @@ -490,7 +490,7 @@ class ProjectManager(object):
>              f.close()
>          return data
>  
> -    def rm_log(self, userid, builddir):
> +    def rm_log(self, userid):
>          ep = self._get_current_project(userid)
>          with open(os.path.join(ep.builddir, 'log.txt'), 'w', 0):
>              pass
> -- 
> 2.19.0.rc2
> 

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 484 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180920/b6d16c14/attachment.sig>


More information about the elbe-devel mailing list