[elbe-devel] [PATCH 22/40] pylint: repomanager - remove unused parameter

Torben Hohn torben.hohn at linutronix.de
Thu Sep 20 13:01:41 CEST 2018


On Fri, Sep 14, 2018 at 01:56:34PM +0200, Manuel Traut wrote:
> component isn't used by _remove_[deb|src]
> 
> Signed-off-by: Manuel Traut <manut at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/repomanager.py | 15 ++++++---------
>  1 file changed, 6 insertions(+), 9 deletions(-)
> 
> diff --git a/elbepack/repomanager.py b/elbepack/repomanager.py
> index e43b2911..173a608d 100644
> --- a/elbepack/repomanager.py
> +++ b/elbepack/repomanager.py
> @@ -228,15 +228,15 @@ class RepoBase(object):
>                      component + ' -P normal -S misc include ' + codename +
>                      ' ' + path)
>  
> -    def _removedeb(self, pkgname, codename, component):
> +    def _removedeb(self, pkgname, codename):
>          self.log.do(
>              "reprepro --basedir %s remove %s %s" %
>              (self.fs.path, codename, pkgname))
>  
>      def removedeb(self, pkgname, component="main"):
> -        self._removedeb(pkgname, self.repo_attr.codename, component)
> +        self._removedeb(pkgname, self.repo_attr.codename)
>  
> -    def _removesrc(self, srcname, codename, component):
> +    def _removesrc(self, srcname, codename):
>          self.log.do(
>              "reprepro --basedir %s removesrc %s %s" %
>              (self.fs.path, codename, srcname))
> @@ -244,18 +244,15 @@ class RepoBase(object):
>      def removesrc(self, path, component="main"):
>          for p in Deb822.iter_paragraphs(file(path)):
>              if 'Source' in p:
> -                self._removesrc(
> -                    p['Source'],
> -                    self.repo_attr.codename,
> -                    component)
> +                self._removesrc(p['Source'], self.repo_attr.codename)
>  
>      def _remove(self, path, codename, component):
>          os.environ['GNUPGHOME'] = "/var/cache/elbe/gnupg"
>          for p in Deb822.iter_paragraphs(file(path)):
>              if 'Source' in p:
> -                self._removesrc(p['Source'], codename, component)
> +                self._removesrc(p['Source'], codename)
>              elif 'Package' in p:
> -                self._removedeb(p['Package'], codename, component)
> +                self._removedeb(p['Package'], codename)
>  
>      def _includedsc(self, path, codename, component):
>          if self.maxsize:
> -- 
> 2.19.0.rc2
> 

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180920/9acfa7af/attachment.sig>


More information about the elbe-devel mailing list