[elbe-devel] [PATCH 00/40] reworked pylint fixes
Torben Hohn
torben.hohn at linutronix.de
Fri Sep 21 11:18:43 CEST 2018
On Fri, Sep 21, 2018 at 11:09:05AM +0200, Manuel Traut wrote:
> Hi Torben,
>
> On Fri, Sep 14, 2018 at 01:56:12PM +0200, Manuel Traut wrote:
> > Hi,
> >
> > i posted a couple of queues with pylint fixes. This is basicly a repost
> > containing all of the changes that are in the previously posted queues.
> > However some easy changes are folded into single bigger patches. To ease
> > the handling of the queue.
>
> thanks for your review!
>
> However some patches didn't get a review so far:
>
> [PATCH 20/40] pylint: hdimg - remove unused parameter rfs
> [PATCH 34/40] pylint: db - _update_proejct_file can be function
> [PATCH 37/40] pylint: directories - annotate usage of global
>
> Did you accidently miss them?
patch 20 got a reviewed-by now.
the other two required some more looking and thinking on my side.
not happy with 34. but i am very unhappy with the whole db code.
34 makes it even more ugly.
37 is probably ok. but i am unsure, if there is a better solution.
>
> I'll merge the patches that got a reviewed-by into devel/elbe-3.0 and push
> the rest into a pylint-needs-more-cleanup git branch.
>
> Thanks,
>
> Manu
>
> > Regards,
> >
> > Manuel
> >
> > Manuel Traut (40):
> > pylintrc: update parameters
> > pylint: apt_mark_delete - remove unused code
> > pylint: test/updated: use optparse defaults
> > pylint: fix error by removing uncalled code
> > pylint: fix import order C0411
> > pylint: test/updated - fix redefine
> > pylint: disable too many arguments error
> > pylint: fix Old-style class defined issues
> > pylint: fix Attribute <x> defined outside __init__
> > pylint: fix 'function already defined' warning
> > pylint: remove/annotate unused imports
> > pylint: ignore apt_pkg.Cache is not iteratable
> > pylint: don't iterate over dict keys
> > pylint: fix has no 'write_licenses' member
> > pylint: fix access of private variable
> > pylint: fix dangerous arguments
> > pylint: rework redefinition of variable 'type'
> > pylint: elbeproject: unused parameter skip_debootstrap
> > pylint: rmlog - remove unused parameter
> > pylint: hdimg - remove unused parameter rfs
> > pylint: db - fix unused parameter p
> > pylint: repomanager - remove unused parameter
> > pylint: CdromInitRepo - remove unused param arch
> > pylint: mark_delete - remove unused param version
> > pylint: updated - remove/annotate unused parameter
> > pylint: virtapt - remove unused parameters
> > pylint: elbeproject - remove unused argument debug
> > pylint: cmd/updated.py - disable unused argument
> > pylint: esoap - annotate or remove unused-parameters
> > pylint: remove unneeded else
> > pylint: docs/conf.py - replace noqa annotates
> > pylint: annotate or remove unused variables
> > pylint: fix call constructor of base class
> > pylint: db - _update_proejct_file can be function
> > pylint: fix do not use `len(SEQUENCE)`
> > pylint: pbuilder - remove unused empty function
> > pylint: directories - annotate usage of global
> > pylint: fstab - rename variables
> > pylint: updated - annotate no self use
> > pylint: virtapt - fix string has no effect
> >
> > .pylintrc | 7 +-
> > docs/conf.py | 8 +-
> > elbepack/aptpkgutils.py | 6 +-
> > elbepack/asciidoclog.py | 2 +-
> > elbepack/asyncworker.py | 9 ++-
> > elbepack/cdroms.py | 3 +-
> > elbepack/commands/buildchroot.py | 10 ---
> > elbepack/commands/check_updates.py | 2 +-
> > elbepack/commands/db.py | 2 +-
> > elbepack/commands/diff.py | 4 +-
> > elbepack/commands/genlicence.py | 4 +-
> > elbepack/commands/init.py | 4 +-
> > elbepack/commands/parselicence.py | 6 +-
> > elbepack/commands/pin_versions.py | 2 +-
> > elbepack/commands/pkgdiff.py | 6 +-
> > elbepack/commands/setsel.py | 2 +-
> > elbepack/commands/show.py | 4 +-
> > elbepack/commands/updated.py | 1 +
> > elbepack/commands/validate.py | 2 +-
> > elbepack/daemons/soap/authentication.py | 2 +
> > elbepack/daemons/soap/datatypes.py | 2 +
> > elbepack/daemons/soap/esoap.py | 11 ++-
> > elbepack/daemons/soap/faults.py | 14 ++--
> > elbepack/db.py | 102 ++++++++++++------------
> > elbepack/dbaction.py | 2 +-
> > elbepack/debianize/base.py | 7 ++
> > elbepack/debianize/debianize.py | 12 +--
> > elbepack/directories.py | 8 +-
> > elbepack/efilesystem.py | 4 +-
> > elbepack/elbeproject.py | 28 +++----
> > elbepack/elbexml.py | 13 ++-
> > elbepack/filesystem.py | 17 +++-
> > elbepack/fstab.py | 18 ++---
> > elbepack/gpg.py | 2 +-
> > elbepack/hdimg.py | 6 +-
> > elbepack/initvmaction.py | 7 --
> > elbepack/licencexml.py | 4 +-
> > elbepack/pbuilder.py | 4 -
> > elbepack/pkgarchive.py | 2 +-
> > elbepack/pkgutils.py | 9 +--
> > elbepack/projectmanager.py | 24 +-----
> > elbepack/repomanager.py | 50 +++++-------
> > elbepack/rfs.py | 4 +-
> > elbepack/rpcaptcache.py | 2 +-
> > elbepack/soapclient.py | 2 +-
> > elbepack/templates.py | 4 +-
> > elbepack/treeutils.py | 16 ++--
> > elbepack/updated.py | 33 ++++----
> > elbepack/virtapt.py | 20 ++---
> > elbepack/xmldefaults.py | 1 -
> > elbepack/xmlpreprocess.py | 10 ++-
> > test/updated.py | 59 +++++---------
> > 52 files changed, 272 insertions(+), 311 deletions(-)
> >
> > --
> > 2.19.0.rc2
> >
--
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
Hinweise zum Datenschutz finden Sie hier (Informations on data privacy
can be found here): https://linutronix.de/kontakt/Datenschutz.php
Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20180921/6412c6b2/attachment.sig>
More information about the elbe-devel
mailing list