[elbe-devel] [PATCH 04/10] gpg: gpg2 requires passphrases for private keys

[Torben Hohn]

On Thu, Apr 04, 2019 at 09:24:51AM +0200, Manuel Traut wrote:
> > > +try:
> > > +    from subprocess import run
> > > +except ImportError:
> > > +    from subprocess import call as run
> > > +
> > 
> > use somthing from elbepack.shellhelper
> > 
> > or log.do, if thats possible, but looks like you dont have
> > the log everywhere... 
> 
> i'll post a v2
> 
> > >      def get_volume_fs(self, volume):
> > > @@ -163,14 +169,16 @@ class RepoBase(object):
> > >              self.log.do(
> > >                  'reprepro --export=force --basedir "' +
> > >                  self.fs.path +
> > > -                '" update')
> > > +                '" update',
> > > +                env_add={'GNUPGHOME': "/var/cache/elbe/gnupg"})
> > 
> > these come in via a patch, that is part of the unmerged proxy env queue.
> > i have sent both patches dealing with GNUPGHOME as a reply to the patch.
> > Please have a look, because they touch a lot more places, and i am not
> > sure, why....
> 
> the patches don't apply anymore. The queue was never completely tested
> and therefore unmerged. What is a real pitty because it addresses a real
> problem.. But it's a different story. Let's not mix things and do this in
> a seperate queue later.

I dont understand, why you add the GNUPGHOME here.

all i am saying is: if you add have to add it here, then you
have to add it in the other places too. This is not a mixup.
The codepaths are probably just not covered by the tests.

I can rebase the patches... 

Or we can look for an explanation, why GNUPGHOME is suddenly needed
here.




> 
>   Manu

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20190404/069f8e9d/attachment.sig>