[elbe-devel] [PATCH v2] Enable initvm creation with newer qemu versions

[Torben Hohn]

On Sat, Apr 06, 2019 at 11:24:41AM +0200, bage at linutronix.de wrote:
> From: Bastian Germann <bage at linutronix.de>
> 
> QEMU >= 2.9 does not have the vlan option for the ancient -net flag.
> Use a current nic configuration. Leave out explicit hubport config.
> 
> This enables `elbe initvm create` on Debian buster which has QEMU 3.1.
> 
> Signed-off-by: Bastian Germann <bage at linutronix.de>

i dont find -nic in the manpage (of stretch)

i seems like we want somethin like:
-netdev user,id=n1 -device virtio-net-pci,netdev=n1

as long as stable is stretch, it is not acceptable to break things on
stretch. if possible, try to use options that work on both buster and
stretch.

And if that does not work, use %if 


> ---
>  elbepack/init/Makefile.mako | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/elbepack/init/Makefile.mako b/elbepack/init/Makefile.mako
> index 0b4960e8..8e8b84d2 100644
> --- a/elbepack/init/Makefile.mako
> +++ b/elbepack/init/Makefile.mako
> @@ -104,8 +104,7 @@ all: .stamps/stamp-install-initial-image
>  		-append 'root=/dev/$(HD_NAME) debconf_priority=critical console=$(CONSOLE) DEBIAN_FRONTEND=text' \
>  		-no-reboot \
>  		-nographic \
> -		-net nic,vlan=1,model=$(NICMODEL),macaddr="${nicmac}" \
> -		-net user,vlan=1 \
> +		-nic user,model=$(NICMODEL),mac="${nicmac}" \
>  		-m $(MEMSIZE) \
>  		-smp $(SMP) \
>  		-usb \
> -- 
> 2.20.1
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 488 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20190408/2c49966e/attachment.sig>