[elbe-devel] [PATCH 00/14] Debianize Urwid

Bastian Germann bage at linutronix.de
Thu Aug 1 15:11:13 CEST 2019


> From: Olivier Dion <dion at linutronix.de>
> 
> npyscreen was a problem for moving Elbe to Python3.  Thus, I've
> rewritten the whole debianize code with urwid, see
> <http://urwid.org/>.

In the current state the patch is only compatible with Python 3. I would
prefer it to be Python 2 compatible so that we can have a transition
phase where Elbe is compatible with both of the Python versions. I
review it any way but you should make sure to post a v2 with this changed.

> 
> The code is copy-paste from one of my previous collaborate project
> with a friend at <https://github.com/abelfodil/inf1900-grader> and is
> under GPL-3.
> 
> I've also made some modifications to fits the debianizer needs.
> 
> As for now, the panels are limited to a single page.  If the terminal
> is too small (height), some widgets might not appeard.
> 
> One way around this would be to seperate the panel in a way multi-form
> does.
> 
> Olivier Dion (14):
>   Debianize - TUI
>   Debianize - TUI signals
>   Debianize - Edit widget factory
>   Debianize - Button widget
>   Debianize - Radio buttons widget
>   Debianize - Grid widget
>   Debianize - Form widget
>   Debianize - Panel widget
>   Debianize - Panel factory
>   Debianize - More panels
>   Debianize commands now use urwid TUI
>   Debianize - Delete old code
>   Add __init__.py for debianize
>   Update debian control for elbe-debianize
> 
>  debian/control                             |  10 +-
>  elbepack/commands/debianize.py             |  15 +--
>  elbepack/debianize/base.py                 | 151 ------------------------
>  elbepack/debianize/base/__init__.py        |   0
>  elbepack/debianize/base/signal.py          |  13 +++
>  elbepack/debianize/base/tui.py             | 181 +++++++++++++++++++++++++++++
>  elbepack/debianize/debianize.py            |  21 ----
>  elbepack/debianize/kernel.py               |  98 ----------------
>  elbepack/debianize/panels/__init__.py      |   0
>  elbepack/debianize/{ => panels}/barebox.py |  50 +++-----
>  elbepack/debianize/panels/base.py          | 115 ++++++++++++++++++
>  elbepack/debianize/panels/factory.py       |  31 +++++
>  elbepack/debianize/panels/kernel.py        |  86 ++++++++++++++
>  elbepack/debianize/{ => panels}/uboot.py   |  69 ++++-------
>  elbepack/debianize/widgets/__init__.py     |   0
>  elbepack/debianize/widgets/button.py       |  44 +++++++
>  elbepack/debianize/widgets/edit.py         |  14 +++
>  elbepack/debianize/widgets/form.py         |  72 ++++++++++++
>  elbepack/debianize/widgets/grid.py         | 130 +++++++++++++++++++++
>  elbepack/debianize/widgets/radio.py        |  53 +++++++++
>  20 files changed, 789 insertions(+), 364 deletions(-)
>  delete mode 100644 elbepack/debianize/base.py
>  create mode 100644 elbepack/debianize/base/__init__.py
>  create mode 100644 elbepack/debianize/base/signal.py
>  create mode 100644 elbepack/debianize/base/tui.py
>  delete mode 100644 elbepack/debianize/debianize.py
>  delete mode 100644 elbepack/debianize/kernel.py
>  create mode 100644 elbepack/debianize/panels/__init__.py
>  rename elbepack/debianize/{ => panels}/barebox.py (52%)
>  create mode 100644 elbepack/debianize/panels/base.py
>  create mode 100644 elbepack/debianize/panels/factory.py
>  create mode 100644 elbepack/debianize/panels/kernel.py
>  rename elbepack/debianize/{ => panels}/uboot.py (57%)
>  create mode 100644 elbepack/debianize/widgets/__init__.py
>  create mode 100644 elbepack/debianize/widgets/button.py
>  create mode 100644 elbepack/debianize/widgets/edit.py
>  create mode 100644 elbepack/debianize/widgets/form.py
>  create mode 100644 elbepack/debianize/widgets/grid.py
>  create mode 100644 elbepack/debianize/widgets/radio.py
> 



More information about the elbe-devel mailing list