[elbe-devel] [PATCH v2 0/2] gpgme/gpg rework

Manuel Traut manut at linutronix.de
Fri Feb 8 17:43:59 CET 2019


Hi Bastian, and others,

@all: because this is about changes that affect security
please have a close look at this. I'm not very familiar
with gpg usage in python. I would welcome if there will
be a review by one who has used this module before.

Bastian, thanks for your work! Basicly it looks OK to me.
But there are two minor things i don't like:
a) from __future__ import absolute_import
b) import gpg as gpgme

Because these are really minor issues i just fixed
them up instead of requesting you to do it. I hope
this is ok for you?

I'll push this version into the test system. Let's
see what happens!

changes since v1:
 * to avoid a) renamed elbepack.gpg into egpg
 * regarding b) dropped 'as gpgme' and fixed up usage

Bastian Germann (1):
  Replace gpgme with maintained gpg module

Manuel Traut (1):
  elbepack.gpg: rename into elbepack.egpg

 README.adoc                        |  2 +-
 debian/control                     |  2 -
 debian/python-elbe-common.install  |  2 +-
 debian/python3-elbe-common.install |  2 +-
 elbepack/commands/remove_sign.py   |  2 +-
 elbepack/commands/sign.py          |  2 +-
 elbepack/debinstaller.py           | 14 ++++--
 elbepack/{gpg.py => egpg.py}       | 75 +++++++++++++-----------------
 elbepack/finetuning.py             | 12 ++---
 elbepack/repomanager.py            |  2 +-
 elbepack/updated.py                |  2 +-
 11 files changed, 53 insertions(+), 64 deletions(-)
 rename elbepack/{gpg.py => egpg.py} (72%)

-- 
2.20.1




More information about the elbe-devel mailing list