[elbe-devel] [PATCH v2 0/2] gpgme/gpg rework

[Manuel Traut]

On 17:43 Fri 08 Feb     , Manuel Traut wrote:
> Hi Bastian, and others,
> 
> @all: because this is about changes that affect security
> please have a close look at this. I'm not very familiar
> with gpg usage in python. I would welcome if there will
> be a review by one who has used this module before.
> 
> Bastian, thanks for your work! Basicly it looks OK to me.
> But there are two minor things i don't like:
> a) from __future__ import absolute_import
> b) import gpg as gpgme
> 
> Because these are really minor issues i just fixed
> them up instead of requesting you to do it. I hope
> this is ok for you?
> 
> I'll push this version into the test system. Let's
> see what happens!

Traceback (most recent call last):
  File "/elbe/elbe", line 55, in <module>
    cmdmod.run_command(sys.argv[2:])
  File "/elbe/elbepack/commands/init.py", line 182, in run_command
    copy_kinitrd(xml.node("/initvm"), out_path)
  File "/elbe/elbepack/debinstaller.py", line 234, in copy_kinitrd
    download_kinitrd(tmp, suite, mirror)
  File "/elbe/elbepack/debinstaller.py", line 172, in download_kinitrd
    download_release(tmp, base_url)
  File "/elbe/elbepack/debinstaller.py", line 148, in download_release
    _, vres = ctx.verify(signed, sig)
  File "/usr/lib/python2.7/dist-packages/gpg/core.py", line 445, in verify
    self.op_verify(signature, signed_data, None)
  File "/usr/lib/python2.7/dist-packages/gpg/core.py", line 151, in wrapper
    return _funcwrap(self, *args)
  File "/usr/lib/python2.7/dist-packages/gpg/core.py", line 135, in _funcwrap
    return errorcheck(result, "Invocation of " + name)
  File "/usr/lib/python2.7/dist-packages/gpg/errors.py", line 62, in errorcheck
    raise GPGMEError(retval, extradata)
gpg.errors.GPGMEError: Invocation of gpgme_op_verify: GPGME: No data
'elbe init' Failed
Giving up

> changes since v1:
>  * to avoid a) renamed elbepack.gpg into egpg
>  * regarding b) dropped 'as gpgme' and fixed up usage
> 
> Bastian Germann (1):
>   Replace gpgme with maintained gpg module
> 
> Manuel Traut (1):
>   elbepack.gpg: rename into elbepack.egpg
> 
>  README.adoc                        |  2 +-
>  debian/control                     |  2 -
>  debian/python-elbe-common.install  |  2 +-
>  debian/python3-elbe-common.install |  2 +-
>  elbepack/commands/remove_sign.py   |  2 +-
>  elbepack/commands/sign.py          |  2 +-
>  elbepack/debinstaller.py           | 14 ++++--
>  elbepack/{gpg.py => egpg.py}       | 75 +++++++++++++-----------------
>  elbepack/finetuning.py             | 12 ++---
>  elbepack/repomanager.py            |  2 +-
>  elbepack/updated.py                |  2 +-
>  11 files changed, 53 insertions(+), 64 deletions(-)
>  rename elbepack/{gpg.py => egpg.py} (72%)
> 
> -- 
> 2.20.1
>