[elbe-devel] [PATCH 2/2] Change distro name in Makefile.mako

Torben Hohn torben.hohn at linutronix.de
Thu Jul 4 15:05:03 CEST 2019


On Thu, Jul 04, 2019 at 10:34:30AM +0200, Olivier Dion wrote:
> 
> On 2019-07-04T09:07:52+0200, Torben Hohn wrote:
> 
> > we also saw this problem again, after we had switched to using libvirt.
> 
> > the fix is here:
> > f5252c11c5672e1aac0c234795f146daeb463f8e
> 
> Err, this is bad practice .. duplicating code ..

erm. well... one of the implementations is in make,
and the other implementation is in mako/python

manut wanted the rsult of elbe init to be transferrable to
another machine. thats the reason why we did not move the implementation
to python.

> 
> But this confirms that this heuristic is only needed on VMWare with
> Stretch.  But in order to test for Buster I would need to test on a
> VMWare and not QEMU.
> 
> I can drop this commit for now and if we have problems in the future we
> can simply add buster to the list of distros to apply the heuristic on
> VMWare.

yeah. lets drop it for now.

> 
> That or we apply the commit (adding buster to the list) and if bugs
> appear for VMWare we revert it ..
> 
> --
> Olivier Dion
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list