[elbe-devel] [PATCH v3 17/52] Add logging to stdout for command buildsdk
Torben Hohn
torben.hohn at linutronix.de
Fri Jul 5 10:58:44 CEST 2019
On Thu, Jun 27, 2019 at 02:44:31PM +0200, dion at linutronix.de wrote:
> From: Olivier Dion <dion at linutronix.de>
make use of the new logging system, and replace all
print() with functions from logging and wrap
it in "with elbe_logging(stdout=True):"
>
> Signed-off-by: Olivier Dion <dion at linutronix.de>
> Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>
> ---
> elbepack/commands/buildsdk.py | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/elbepack/commands/buildsdk.py b/elbepack/commands/buildsdk.py
> index 5b4debfc..f3bf4141 100644
> --- a/elbepack/commands/buildsdk.py
> +++ b/elbepack/commands/buildsdk.py
> @@ -7,9 +7,11 @@ from __future__ import print_function
>
> from optparse import OptionParser
> import sys
> +import logging
>
> from elbepack.elbeproject import ElbeProject
> from elbepack.elbexml import ValidationError
> +from elbepack.log import elbe_logging
>
>
> def run_command(argv):
> @@ -28,12 +30,12 @@ def run_command(argv):
> oparser.print_help()
> sys.exit(20)
>
> - try:
> - project = ElbeProject(args[0], override_buildtype=opt.buildtype,
> - skip_validate=opt.skip_validation)
> - except ValidationError as e:
> - print(str(e))
> - print("xml validation failed. Bailing out")
> - sys.exit(20)
> + with elbe_logging(stdout=True):
> + try:
> + project = ElbeProject(args[0], override_buildtype=opt.buildtype,
> + skip_validate=opt.skip_validation)
> + except ValidationError:
> + logging.exception("xml validation failed. Bailing out")
> + sys.exit(20)
>
> - project.build_sdk()
> + project.build_sdk()
> --
> 2.11.0
>
>
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel
--
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
Hinweise zum Datenschutz finden Sie hier (Informations on data privacy
can be found here): https://linutronix.de/kontakt/Datenschutz.php
Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen |
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
More information about the elbe-devel
mailing list