[elbe-devel] [PATCH v3 24/52] Add logging to opt.output for command hdimg

[Olivier Dion]

On 2019-07-05T11:05:49+0200, Torben Hohn wrote:

> On Thu, Jun 27, 2019 at 02:44:38PM +0200, dion at linutronix.de wrote:
> > From: Olivier Dion <dion at linutronix.de>
> >
> > Signed-off-by: Olivier Dion <dion at linutronix.de>
> > ---
> >  elbepack/commands/hdimg.py | 22 +++++++++++++---------
> >  1 file changed, 13 insertions(+), 9 deletions(-)
> >
> > diff --git a/elbepack/commands/hdimg.py b/elbepack/commands/hdimg.py
> > index 85111b5c..cf3d96b6 100644
> > --- a/elbepack/commands/hdimg.py
> > +++ b/elbepack/commands/hdimg.py
> > @@ -8,11 +8,14 @@
> >  from __future__ import print_function
> >
> >  import sys
> > +import os
> > +import logging
> >
> >  from optparse import OptionParser
> >
> >  from elbepack.elbeproject import ElbeProject
> >  from elbepack.elbexml import ValidationError
> > +from elbepack.log import elbe_logging
> >
> >
> >  def run_command(argv):
> > @@ -64,13 +67,14 @@ def run_command(argv):
> >          oparser.print_help()
> >          sys.exit(20)
> >
> > -    try:
> > -        project = ElbeProject(opt.target, override_buildtype=opt.buildtype,
> > -                              xmlpath=args[0], logpath=opt.output,
> > -                              skip_validate=opt.skip_validation)
> > -    except ValidationError as e:
> > -        print(str(e))
> > -        print("xml validation failed. Bailing out")
> > -        sys.exit(20)
> > +    with elbe_logging(opt.target):

> this logs to target, but it should be logging to opt.output, shouldnt it
> ?

True

> > +        try:
> > +            project = ElbeProject(opt.target,
> > +                                  override_buildtype=opt.buildtype,
> > +                                  xmlpath=args[0], logpath=opt.output,
> > +                                  skip_validate=opt.skip_validation)

> logpath ? isnt this attribute removed ?

This is done later.  Although it could be done there, it won't change
anything.

See "Validation and report now use logging"

--
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen