[elbe-devel] [PATCH v3 39/52] Fix style for "cdroms.py"

Torben Hohn torben.hohn at linutronix.de
Fri Jul 5 13:28:22 CEST 2019


On Thu, Jun 27, 2019 at 02:44:53PM +0200, dion at linutronix.de wrote:
> From: Olivier Dion <dion at linutronix.de>
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/cdroms.py | 16 ++++++++--------
>  1 file changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/elbepack/cdroms.py b/elbepack/cdroms.py
> index 60265de2..2d8649fc 100644
> --- a/elbepack/cdroms.py
> +++ b/elbepack/cdroms.py
> @@ -66,9 +66,9 @@ def mk_source_cdrom(rfs, arch, codename, init_codename, target,
>              dsc = cache.download_source(pkg.name, '/var/cache/elbe/sources')
>              repo.includedsc(dsc, force=True)
>          except ValueError:
> -            logging.error("No sources for package '%s'" % pkg_id)
> +            logging.error("No sources for package '%s'", pkg_id)
>          except FetchError:
> -            logging.error("Source for package '%s' could not be downloaded" % pkg_id)
> +            logging.error("Source for package '%s' could not be downloaded", pkg_id)
>  
>      # elbe fetch_initvm_pkgs has downloaded all sources to
>      # /var/cache/elbe/sources
> @@ -140,11 +140,11 @@ def mk_binary_cdrom(rfs, arch, codename, init_codename, xml, target,
>                                              pkg.installed_version)
>                  target_repo.includedeb(deb, 'main')
>              except ValueError:
> -                logging.error("No package '%s'" % pkg_id)
> +                logging.error("No package '%s'", pkg_id)
>              except FetchError:
> -                logging.error("Package '%s' could not be downloaded" % pkg_id)
> +                logging.error("Package '%s' could not be downloaded", pkg_id)
>              except TypeError:
> -                logging.error("Package '%s' missing name or version" % pkg_id)
> +                logging.error("Package '%s' missing name or version", pkg_id)
>  
>      cache = get_rpcaptcache(rfs, arch)
>      pkglist = cache.get_installed_pkgs()
> @@ -158,11 +158,11 @@ def mk_binary_cdrom(rfs, arch, codename, init_codename, xml, target,
>          except KeyError as ke:
>              logging.error(str(ke))
>          except ValueError:
> -            logging.error("No package %s" % pkg_id)
> +            logging.error("No package '%s'", pkg_id)
>          except FetchError:
> -            logging.error("Package %s could not be downloaded" % pkg_id)
> +            logging.error("Package '%s' could not be downloaded", pkg_id)
>          except TypeError:
> -            logging.error("Package %s missing name or version")
> +            logging.error("Package '%s' missing name or version", pkg_id)
>  
>      target_repo.finalize()
>  
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list