[elbe-devel] [PATCH 3/5] Add XML tag's definition for ISO image options

Olivier Dion dion at linutronix.de
Wed Jul 17 11:06:04 CEST 2019


On 2019-07-17T09:41:52+0200, Kurt Kanzenbach wrote:

> Any reason why the default is set to false? I'd prefer a strict
> validation by default.

The geniso command looks like this before the patch:

 genisoimage -o %s -J -joliet-long -R %s

The flag -J is a Joliet extension that allows Joliet directory in
addition to regular ISO9660 filenames.  Filepath are in Unicode and up
to 64 characters (103 with -joliet-long).

The rational behind the strict attribute is to enforce ISO9660 standard
even though the image is generated with the Joliet extension.  Thus the
iso image is not conformed with ISO9660.

I think that it would be better to make strict ISO9660 the default and
check this in the preprocessor.  Joliet extension can be specify with an
attribute like 'joliet="true" joliet-long="true"' or something similar,
changing the behavior of the preprocessor and adding the corresponding
flags to the geniso command.  This however risk of breaking existing
working XML files.

Commit b62e81ff643819576a84cb71259872226afc880e is the one introducing
the geniso command.  We should probably wait and ask Torben as for why
Joliet is the default.

Commit 995eb2d62147b46e51361c73973f3a767d513e58 already provide an hint
with the rational of joliet-long.

--
Olivier Dion
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen



More information about the elbe-devel mailing list