[elbe-devel] [PATCH 2/5] Add ISO files options for source cdroms

[Kurt Kanzenbach]

Hi,

On Wed, Jul 17, 2019 at 10:49:56AM +0200, Olivier Dion wrote:
>
> On 2019-07-17T09:38:09+0200, Kurt Kanzenbach wrote:
>
> > Why not use hashes consistently? I'd prefer something like
>
> >  str_type = encoding[iso_options[opt_name]["str_type"]]
>
> > > +    if len(text) > iso_options[opt_name][1]:
>
> >  if len(text) > iso_options[opt_name]["len"]:
>
> > and so on. It makes it easier to read.
>
> Old C habit I guess.  I can either change it to a dict if you want.

Next time.

Thanks,
Kurt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.linutronix.de/pipermail/elbe-devel/attachments/20190718/7d5c5567/attachment.sig>