[elbe-devel] [PATCH 00/32] Sane Logging

dion at linutronix.de dion at linutronix.de
Fri Jun 14 22:13:14 CEST 2019


From: Olivier Dion <dion at linutronix.de>

This patch is _not_ intended to improve logging for the user.  It's
more focus toward removing the nightmare of logging for the
developers.

Although, I did improve, in _my opinion_, the format of the logged
message.

* Major changes

  - RPC Apt Cache more verbose
  - Make logging not a nightmare for maintainers
  - Improve readability of message

* validation.txt

  It doesn't exist anymore.  Don't look for it.  It's all in
  log.txt now.

* Tests and Stats

  Successfull submission to initvm with
  
    - x86_64-docker.xml
    - powerpc.xml
    - x86_32-pc-hdimg-with-include-development.xml

  For x86_32-pc-hdimg-with-include-development.xml, log.txt is around
  200k more long than ELBE v8, and yet every messages are shorter in
  general.

* What's next?

  Need testing with bad submissions to initvm, so that we can test all
  (hopefully) code paths.  It would also greatly provide insight on
  where ELBE lack of logging.

  Making ELBE not lying about "Build finished successfully" is also
  part of the next step.

* Note

  I've triple check with Grep everything.  I don't think I've missed
  something and ASCIIDocLog is definitely nuked from ELBE.  However,
  maybe I did ..


Olivier Dion (32):
  Sanitize output for soapclient
  log.py - New logging system
  do and chroot in 'shellhelper.py'
  ASCIIDocLog compatible with new logging system
  Add logging to db for projectmanager
  Add logging to stdout for command buildsdk
  Add logging to stdout for command buildchroot
  Add logging to stdout for command buildsysroot
  Add logging to stdout for command chroot
  Add logging to stdout for command gen_update
  Add logging to stdout for command fetch_initvm_pkgs
  Add logging to stdout for command genlicense
  Add logging to opt.output for command hdimg
  Add logging to opt.output for command toolchainextract
  Add logging to opt.output for command adjustpkgs
  Add logging to opt.log for command mkcdrom
  Nuke ASCIIDocLog from BuildEnv
  Nuke ASCIIDocLog from repomanager
  Nuke ASCIIDocLog from RPCAPTCache
  Nuke ASCIIDocLog from finetuning
  Nuke ASCIIDocLog from fstab
  Nuke ASCIIDocLog from hdimg
  Nuke ASCIIDocLog from packers
  Nuke ASCIIDocLog from efilesystem
  Nuke ASCIIDocLog from bin/src cdrom
  Nuke ASCIIDocLog from pbuilder
  Nuke ASCIIDocLog from "pkgutils.py"
  Nuke ASCIIDocLog from AsyncWorker
  Nuke ASCIIDocLog from gen_update_pkg
  Remove validation.txt
  Nuke ASCIIDocLog from elbeproject
  Remove "asciidoclog.py" from ELBE

 elbepack/asciidoclog.py                | 123 -------------
 elbepack/asyncworker.py                | 319 +++++++++++++++------------------
 elbepack/cdroms.py                     | 104 ++++-------
 elbepack/commands/adjustpkgs.py        |  17 +-
 elbepack/commands/buildchroot.py       |   9 +-
 elbepack/commands/buildsdk.py          |   2 +
 elbepack/commands/buildsysroot.py      |   2 +
 elbepack/commands/chroot.py            |  11 +-
 elbepack/commands/fetch_initvm_pkgs.py |  48 ++---
 elbepack/commands/gen_update.py        |   5 +-
 elbepack/commands/genlicence.py        |   6 +-
 elbepack/commands/hdimg.py             |   8 +-
 elbepack/commands/mkcdrom.py           |  17 +-
 elbepack/commands/toolchainextract.py  |  18 +-
 elbepack/db.py                         |  10 +-
 elbepack/dump.py                       | 136 ++++++--------
 elbepack/efilesystem.py                |  44 +++--
 elbepack/elbeproject.py                | 294 ++++++++++++++----------------
 elbepack/filesystem.py                 |   9 +-
 elbepack/finetuning.py                 | 263 +++++++++++++--------------
 elbepack/fstab.py                      |   8 +-
 elbepack/hdimg.py                      | 201 ++++++++++-----------
 elbepack/initvmaction.py               |  19 --
 elbepack/log.py                        | 105 +++++++++++
 elbepack/packers.py                    |  22 +--
 elbepack/pbuilder.py                   |   2 +-
 elbepack/pkgarchive.py                 |  53 ++----
 elbepack/pkgutils.py                   |  29 ++-
 elbepack/projectmanager.py             |  10 +-
 elbepack/repomanager.py                |  85 ++++-----
 elbepack/rfs.py                        | 151 ++++++++--------
 elbepack/rpcaptcache.py                |  89 +++++----
 elbepack/shellhelper.py                |  62 +++++++
 elbepack/soapclient.py                 |   4 +-
 elbepack/updatepkg.py                  |   8 +-
 35 files changed, 1085 insertions(+), 1208 deletions(-)
 delete mode 100644 elbepack/asciidoclog.py
 create mode 100644 elbepack/log.py

-- 
2.11.0




More information about the elbe-devel mailing list