[elbe-devel] [PATCH 00/13] Issue 172 - use check_call instead of os.system
dion at linutronix.de
dion at linutronix.de
Mon Jun 24 12:48:40 CEST 2019
From: Olivier Dion <dion at linutronix.de>
See https://github.com/Linutronix/elbe/issues/172
> check_call raises an exception. Please replace all os.system calls
> that return code is not checked with check_call(..., shell=True) to
> improve error handling."
All calls to os.system were not checked, this might result in new
exceptions that weren't there before.
Other 'system' calls are made via shellhelper::system, which already
throws a CommandError exception, thus they weren't touched.
Olivier Dion (13):
Change os.sytem to call_check for "check_updates.py"
Change os.sytem to call_check for "chroot.py"
Change os.sytem to call_check for "init.py"
Change os.sytem to call_check for "toolchainextract.py"
Change os.sytem to call_check for "barebox.py"
Change os.sytem to call_check for "kernel.py"
Change os.sytem to call_check for "debpkg.py"
Change os.sytem to call_check for "efilesystem.py"
Change os.sytem to call_check for "elbeproject.py"
Change os.sytem to call_check for "initvmaction.py"
Change os.sytem to call_check for "updated.py"
Change os.sytem to call_check for "updatedpkg.py"
Change os.sytem to call_check for "virtapt.py"
elbepack/commands/check_updates.py | 6 ++--
elbepack/commands/chroot.py | 7 +++--
elbepack/commands/init.py | 14 ++++-----
elbepack/commands/toolchainextract.py | 4 ++-
elbepack/debianize/barebox.py | 3 +-
elbepack/debianize/kernel.py | 3 +-
elbepack/debpkg.py | 21 ++++++-------
elbepack/efilesystem.py | 58 +++++++++++++++++++++--------------
elbepack/elbeproject.py | 6 ++--
elbepack/initvmaction.py | 5 ++-
elbepack/updated.py | 9 +++---
elbepack/updatepkg.py | 14 ++++-----
elbepack/virtapt.py | 6 ++--
13 files changed, 87 insertions(+), 69 deletions(-)
--
2.11.0
More information about the elbe-devel
mailing list