[elbe-devel] [PATCH v2 04/15] Change os.sytem to shellhelper::system for "toolchainextract.py"

Torben Hohn torben.hohn at linutronix.de
Tue Jun 25 13:57:31 CEST 2019


On Tue, Jun 25, 2019 at 01:48:01PM +0200, Torben Hohn wrote:
> 
> Please convert it to use TmpdirFilesystem here.

hmm... looking at this stuff a little closer...
we should probably just drop it.

Because this workflow is not supported anymore.
> 
> 
> On Mon, Jun 24, 2019 at 05:39:01PM +0200, dion at linutronix.de wrote:
> > From: Olivier Dion <dion at linutronix.de>
> > 
> > Signed-off-by: Olivier Dion <dion at linutronix.de>
> > ---
> >  elbepack/commands/toolchainextract.py | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/elbepack/commands/toolchainextract.py b/elbepack/commands/toolchainextract.py
> > index aaf26ac2..566afc8e 100644
> > --- a/elbepack/commands/toolchainextract.py
> > +++ b/elbepack/commands/toolchainextract.py
> > @@ -9,11 +9,13 @@ from tempfile import mkdtemp
> >  
> >  import os
> >  
> > +
> >  from elbepack.xmldefaults import ElbeDefaults
> >  from elbepack.repomanager import ToolchainRepo
> >  from elbepack.debpkg import build_binary_deb
> >  from elbepack.toolchain import get_toolchain
> >  from elbepack.asciidoclog import StdoutLog
> > +from elbepack.shellhelper import system
> >  
> >  
> >  def run_command(argv):
> > @@ -78,4 +80,4 @@ def run_command(argv):
> >          repo.includedeb(os.path.join(tmpdir, p))
> >  
> >      repo.finalize()
> > -    os.system('rm -r "%s"' % tmpdir)
> > +    system('rm -r "%s"' % tmpdir)
> > -- 
> > 2.11.0
> > 
> > 
> > _______________________________________________
> > elbe-devel mailing list
> > elbe-devel at linutronix.de
> > https://lists.linutronix.de/mailman/listinfo/elbe-devel
> 
> -- 
> Torben Hohn
> Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
> Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99
> 
> Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
> can be found here): https://linutronix.de/kontakt/Datenschutz.php
> 
> Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
> Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
> 806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list