[elbe-devel] [PATCH v2 09/15] Change os.sytem to shellhelper::system for "elbeproject.py"

[Torben Hohn]

On Mon, Jun 24, 2019 at 05:39:06PM +0200, dion at linutronix.de wrote:
> From: Olivier Dion <dion at linutronix.de>
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/elbeproject.py | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/elbeproject.py b/elbepack/elbeproject.py
> index 073bfb15..a6256b1f 100644
> --- a/elbepack/elbeproject.py
> +++ b/elbepack/elbeproject.py
> @@ -13,6 +13,7 @@ import os
>  import datetime
>  import io
>  
> +
>  from elbepack.asciidoclog import ASCIIDocLog, StdoutLog
>  from elbepack.shellhelper import CommandError
>  
> @@ -37,6 +38,7 @@ from elbepack.repomanager import ProjectRepo
>  from elbepack.config import cfg
>  from elbepack.templates import write_pack_template
>  from elbepack.finetuning import do_prj_finetuning
> +from elbepack.shellhelper import system
>  
>  
>  class IncompatibleArchitectureException(Exception):
> @@ -63,7 +65,7 @@ class UnsupportedSDKException(Exception):
>  
>  
>  def test_gen_sdk_scripts():
> -    os.system("mkdir -p /tmp/test/sdk")
> +    system("mkdir -p /tmp/test/sdk")
>      gen_sdk_scripts('armhf-linux-gnueabihf',
>                      'ARM',
>                      'testproject',
> @@ -659,7 +661,7 @@ class ElbeProject (object):
>  
>          self.targetfs.pack_images(self.builddir)
>  
> -        os.system('cat "%s"' % self.validationpath)
> +        system('cat "%s"' % self.validationpath)
>  
>      def pdebuild_init(self):
>          # Remove pdebuilder directory, containing last build results
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner