[elbe-devel] [PATCH v2 14/15] Change check_call to shellhelper::system for "uboot.py"

Torben Hohn torben.hohn at linutronix.de
Tue Jun 25 14:10:02 CEST 2019


On Mon, Jun 24, 2019 at 05:39:11PM +0200, dion at linutronix.de wrote:
> From: Olivier Dion <dion at linutronix.de>
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/debianize/uboot.py | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/debianize/uboot.py b/elbepack/debianize/uboot.py
> index 767281ce..4f53d254 100644
> --- a/elbepack/debianize/uboot.py
> +++ b/elbepack/debianize/uboot.py
> @@ -8,12 +8,12 @@ import os
>  
>  from time import sleep
>  from shutil import copyfile
> -from subprocess import check_call
>  
>  from npyscreen import TitleText, notify
>  
>  from elbepack.directories import mako_template_dir
>  from elbepack.debianize.base import DebianizeBase, template
> +from elbepack.shellhelper import system
>  
>  from pkg_resources import parse_version as V
>  
> @@ -91,7 +91,7 @@ class UBoot (DebianizeBase):
>              ' -v ' + self.deb['p_version'] + \
>              ' --create -M -D ' + self.deb['release'] + \
>              ' "generated by elbe debianize"'
> -        check_call(cmd, shell=True)
> +        system(cmd)
>  
>          copyfile(os.path.join(self.tmpl_dir, 'u-boot-image.install'),
>                   'debian/u-boot-image-' + pkg_name + '.install')
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner



More information about the elbe-devel mailing list