[elbe-devel] [PATCH v3 13/15] Change check_call to shellhelper::system for "archivedir.py"

[Torben Hohn]

On Wed, Jun 26, 2019 at 10:40:17AM +0200, dion at linutronix.de wrote:
> From: Olivier Dion <dion at linutronix.de>
> 
> Signed-off-by: Olivier Dion <dion at linutronix.de>

Reviewed-by: Torben Hohn <torben.hohn at linutronix.de>

> ---
>  elbepack/archivedir.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/elbepack/archivedir.py b/elbepack/archivedir.py
> index e4666e3e..10155228 100644
> --- a/elbepack/archivedir.py
> +++ b/elbepack/archivedir.py
> @@ -15,9 +15,10 @@ except ImportError:
>  
>  from base64 import standard_b64encode
>  from bz2 import compress as bz2compress
> -from subprocess import CalledProcessError, check_call
> +from subprocess import CalledProcessError
>  
>  from elbepack.treeutils import etree
> +from elbepack.shellhelper import system
>  
>  class ArchivedirError(Exception):
>      pass
> @@ -44,7 +45,7 @@ def collect(tararchive, path, keep):
>      else:
>          cmd = 'tar rf ' + tararchive + ' --owner=root --group=root -C '
>      cmd += path + ' .'
> -    check_call(cmd, shell=True)
> +    system(cmd)
>  
>  def chg_archive(xml, path, keep):
>      if os.path.isdir(path):
> -- 
> 2.11.0
> 
> 
> _______________________________________________
> elbe-devel mailing list
> elbe-devel at linutronix.de
> https://lists.linutronix.de/mailman/listinfo/elbe-devel

-- 
Torben Hohn
Linutronix GmbH | Bahnhofstrasse 3 | D-88690 Uhldingen-Mühlhofen
Phone: +49 7556 25 999 18; Fax.: +49 7556 25 999 99

Hinweise zum Datenschutz finden Sie hier (Informations on data privacy 
can be found here): https://linutronix.de/kontakt/Datenschutz.php

Linutronix GmbH | Firmensitz (Registered Office): Uhldingen-Mühlhofen | 
Registergericht (Registration Court): Amtsgericht Freiburg i.Br., HRB700 
806 | Geschäftsführer (Managing Directors): Heinz Egger, Thomas Gleixner